MissingMethodException on getting ResourceInstance from ODataResourceSerializer #2558

komdil · 2021-09-01T10:48:08Z

Issues

This pull request fixes issue #2557.

Description

Adding constructor param on generic SelectExpandWrapper class for setting instance of resource

Checklist (Uncheck if it is not completed)

Test cases added
Build and test with one-click build and test script passed

Additional work necessary

If documentation update is needed, please add "Docs Needed" label to the issue and provide details about the required document change in the issue.

komdil · 2021-09-06T06:55:11Z

I couldn't solve the tests. I think someone needs to take a look.
I think BuildResourceInstance is working wrong because it is trying to create an instance of the resource.
The instance was already created. It may cause a lot of problems (performance). One of the big problems:
It is creating instances of resources and setting property. What if the property setter will not allow it or have autocorrect. For example,
Return only one instance from controller
Put this logic:

static bool alreadySet;
        string firstName;
        public string FirstName
        {
            get
            {
                return firstName;
            }
            set
            {
                if (alreadySet)
                {
                    throw new InvalidOperationException("Do not set it again!");
                }
                firstName = value;
                alreadySet = true;
            }
        }

Send query https://localhost:5001/oData/Student?$select=Id,FirstName

It will throw exception from DeserializationHelpers.SetProperty(resource, propertyName, value); 261 line ResourceContext.cs

@xuzhg I think these changes were made by you.

KenitoInc

It seems this PR is addressing a specific use case for you.
In the next release of WebApi Aspnetcore v8.x, we will have the ability to inject a custom implementation of the SelectExpandBinder (PR). That should work for you.

komdil · 2021-09-23T08:48:17Z

It seems this PR is addressing a specific use case for you.
In the next release of WebApi Aspnetcore v8.x, we will have the ability to inject a custom implementation of the SelectExpandBinder (PR). That should work for you.

Maybe, but I am using v7.x. Is it possible to merge that branch in version 7.x also?

KenitoInc · 2021-09-28T06:37:22Z

It seems this PR is addressing a specific use case for you.
In the next release of WebApi Aspnetcore v8.x, we will have the ability to inject a custom implementation of the SelectExpandBinder (PR). That should work for you.

Maybe, but I am using v7.x. Is it possible to merge that branch in version 7.x also?

@xuzhg @gathogojr What do you think?

komdil · 2021-09-30T07:58:29Z

It seems this PR is addressing a specific use case for you.
In the next release of WebApi Aspnetcore v8.x, we will have the ability to inject a custom implementation of the SelectExpandBinder (PR). That should work for you.

Maybe, but I am using v7.x. Is it possible to merge that branch in version 7.x also?

@xuzhg @gathogojr What do you think?

I am seeing Activator.CreateInstanse on BuildResource method on v.8x also. I think the problem exists on v.8x also

corranrogue9 · 2021-10-18T01:11:58Z

src/Microsoft.AspNet.OData.Shared/Query/Expressions/SelectExpandBinder.cs

@@ -293,9 +293,10 @@ internal Expression ProjectElement(Expression source, SelectExpandClause selectE
                LinqParameterContainer.Parameterize(typeof(string), _modelID) :
                Expression.Constant(_modelID);
            wrapperTypeMemberAssignments.Add(Expression.Bind(wrapperProperty, wrapperPropertyValueExpression));
-
+            bool instanseOfWrapperClassWasSet = false;


super nit: spelling "instance"

corranrogue9 · 2021-10-18T01:16:17Z

test/UnitTest/Microsoft.AspNet.OData.Test.Shared/Query/Expressions/SelectExpandBinderTest.cs

@@ -109,10 +109,12 @@ public void Bind_GeneratedExpression_ContainsExpandedObject()

            // Assert
            IEnumerator enumerator = queryable.GetEnumerator();
+            IEnumerator _querableEnumerator = _queryable.GetEnumerator();


IEnumerator implements IDisposable. Please wrap this in a using block

mikepizzo · 2021-11-04T22:45:35Z

src/Microsoft.AspNet.OData.Shared/Query/Expressions/SelectExpandBinder.cs

-            return Expression.MemberInit(Expression.New(wrapperType), wrapperTypeMemberAssignments);
+
+            if (instanseOfWrapperClassWasSet)
+                return Expression.MemberInit(Expression.New(wrapperType), wrapperTypeMemberAssignments);


as per code guidelines, please enclose body of conditional in braces (even if it's a single line). Improves code readability and reduces introducing logical errors later.

pull-request-quantifier-deprecated · 2021-11-22T10:58:25Z

This PR has 34 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details

Label      : Extra Small
Size       : +21 -13
Percentile : 13.6%

Total files changed: 4

Change summary by file extension:
.cs : +21 -13

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

Fast and predictable releases to production:
- Optimal size changes are more likely to be reviewed faster with fewer
  iterations.
- Similarity in low PR complexity drives similar review times.
Review quality is likely higher as complexity is lower:
- Bugs are more likely to be detected.
- Code inconsistencies are more likely to be detetcted.
Knowledge sharing is improved within the participants:
- Small portions can be assimilated better.
Better engineering practices are exercised:
- Solving big problems by dividing them in well contained, smaller problems.
- Exercising separation of concerns within the code changes.

What can I do to optimize my changes

Use the PullRequestQuantifier to quantify your PR accurately
- Create a context profile for your repo using the context generator
- Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
- Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
- Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
Change your engineering behaviors
- For PRs that fall outside of the desired spectrum, review the details and check if:
  - Your PR could be split in smaller, self-contained PRs instead
  - Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

One line was added: +1 -0
One line was deleted: +0 -1
One line was modified: +1 -1 (git diff doesn't know about modified, it will
interpret that line like one addition plus one deletion)
Change percentiles: Change characteristics (addition, deletion, modification)
of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

Sreejithpin · 2021-12-08T07:35:26Z

@komdil Can you please look at the review comments., thanks

komdil · 2021-12-09T03:34:50Z

@komdil Can you please look at the review comments., thanks

@Sreejithpin The tests are failing. It looks this solution will not work for solving this problem. I don't have next steps

corranrogue9 · 2022-04-28T23:21:34Z

@komdil, I'd like to help out and take a look, but it seems that I can't kick off a new build. Do you mind re-running the checks?

KenitoInc · 2023-03-02T11:44:23Z

@komdil
These is how expressions are generated using a few examples

GET http://localhost:6143/odata/Books?$select=Title

$it => new SelectSome`1() 
    {
        ModelID = value(Microsoft.AspNet.OData.Query.Expressions.LinqParameterContainer+TypedLinqParameterContainer`1[System.String]).TypedProperty,
        Container = new NamedPropertyWithNext0`1() 
        {
            Name = "Title",
            Value = $it.Title,
            Next0 = new AutoSelectedNamedProperty`1() 
            {
                Name = "Id",
                Value = Convert($it.Id, Nullable`1)
            }
        }
    }

GET http://localhost:6143/odata/Books?$select=*

$it => new SelectAll`1() {
    ModelID = value(Microsoft.AspNet.OData.Query.Expressions.LinqParameterContainer+TypedLinqParameterContainer`1[System.String]).TypedProperty,
    Instance = $it,
    UseInstanceForProperties = True
    }
}

GET http://localhost:6143/odata/Books?$expand=Authors

$it => new SelectAllAndExpand`1() 
    {
        ModelID = value(Microsoft.AspNet.OData.Query.Expressions.LinqParameterContainer+TypedLinqParameterContainer`1[System.String]).TypedProperty,
        Instance = $it,
        UseInstanceForProperties = True,
        Container = new NamedProperty`1() 
            {
                Name = "Authors",
                Value = $it.Authors.Select($it => new SelectAll`1() 
                    {
                        ModelID = value(Microsoft.AspNet.OData.Query.Expressions.LinqParameterContainer+TypedLinqParameterContainer`1[System.String]).TypedProperty,
                        Instance = $it,
                        UseInstanceForProperties = True
                    }
                )
            }
    }

We don't set the Instance in all scenarios.
For example in $Select=Title, we don't need the Books instance since we have the Title in the Container.

Your PR introduces an Instance property in all scenarios.

add ctors

66f7720

pull-request-quantifier-deprecated bot added the Small label Sep 1, 2021

Dilshod Komilov added 4 commits September 1, 2021 16:49

change behaviors

c85d30f

create one more constructor

a1855f0

run with parameterless constructor

ed8c561

undo changes

5aee3d0

pull-request-quantifier-deprecated bot added Extra Small and removed Small labels Sep 2, 2021

fix failed tests

9731199

Dilshod Komilov added 2 commits September 6, 2021 14:07

fix

11ad626

remove flag

119f2a9

KenitoInc requested review from KenitoInc, ElizabethOkerio, gathogojr, habbes, marabooy, mikepizzo, Sreejithpin and xuzhg September 23, 2021 08:19

KenitoInc reviewed Sep 23, 2021

View reviewed changes

corranrogue9 reviewed Oct 18, 2021

View reviewed changes

corranrogue9 previously approved these changes Oct 18, 2021

View reviewed changes

mikepizzo reviewed Nov 4, 2021

View reviewed changes

fix

dfb9bac

xuzhg dismissed corranrogue9’s stale review via dfb9bac March 8, 2022 19:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MissingMethodException on getting ResourceInstance from ODataResourceSerializer #2558

MissingMethodException on getting ResourceInstance from ODataResourceSerializer #2558

komdil commented Sep 1, 2021 •

edited

Loading

komdil commented Sep 6, 2021

KenitoInc left a comment

komdil commented Sep 23, 2021

KenitoInc commented Sep 28, 2021

komdil commented Sep 30, 2021

corranrogue9 Oct 18, 2021

corranrogue9 Oct 18, 2021

mikepizzo Nov 4, 2021

pull-request-quantifier-deprecated bot commented Nov 22, 2021

What can I do to optimize my changes

How to interpret the change counts in git diff output

Sreejithpin commented Dec 8, 2021

komdil commented Dec 9, 2021

corranrogue9 commented Apr 28, 2022

KenitoInc commented Mar 2, 2023

MissingMethodException on getting ResourceInstance from ODataResourceSerializer #2558

Are you sure you want to change the base?

MissingMethodException on getting ResourceInstance from ODataResourceSerializer #2558

Conversation

komdil commented Sep 1, 2021 • edited Loading

Issues

Description

Checklist (Uncheck if it is not completed)

Additional work necessary

komdil commented Sep 6, 2021

KenitoInc left a comment

Choose a reason for hiding this comment

komdil commented Sep 23, 2021

KenitoInc commented Sep 28, 2021

komdil commented Sep 30, 2021

corranrogue9 Oct 18, 2021

Choose a reason for hiding this comment

corranrogue9 Oct 18, 2021

Choose a reason for hiding this comment

mikepizzo Nov 4, 2021

Choose a reason for hiding this comment

pull-request-quantifier-deprecated bot commented Nov 22, 2021

What can I do to optimize my changes

How to interpret the change counts in git diff output

Sreejithpin commented Dec 8, 2021

komdil commented Dec 9, 2021

corranrogue9 commented Apr 28, 2022

KenitoInc commented Mar 2, 2023

komdil commented Sep 1, 2021 •

edited

Loading