Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optee_rust_examples_ext: Migrate to standard environment vars #715

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

b49020
Copy link
Contributor

@b49020 b49020 commented Dec 29, 2023

Allow OP-TEE rust examples to be compiled using standard OP-TEE environment variables:

  • CROSS_COMPILE
  • TA_DEV_KIT_DIR
  • OPTEE_CLIENT_EXPORT

@b49020
Copy link
Contributor Author

b49020 commented Dec 29, 2023

@DemesneGH Fyi..

common.mk Outdated Show resolved Hide resolved
@b49020
Copy link
Contributor Author

b49020 commented Jan 2, 2024

Addressed review comments.

Copy link
Contributor

@jforissier jforissier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one comment below.

Acked-by: Jerome Forissier <jerome.forissier@linaro.org>

br-ext/package/optee_rust_examples_ext/Config.in Outdated Show resolved Hide resolved
@b49020 b49020 force-pushed the master branch 2 times, most recently from 45a6dc8 to 010dd7f Compare January 2, 2024 11:09
@b49020
Copy link
Contributor Author

b49020 commented Jan 2, 2024

Addressed comment, tag applied.

@b49020
Copy link
Contributor Author

b49020 commented Jan 3, 2024

@DemesneGH can I get your ack here?

@DemesneGH
Copy link
Contributor

Acked-by: Yuan Zhuang <yuanz@apache.org>

Allow OP-TEE rust examples to be compiled using standard OP-TEE
environment variables:
- CROSS_COMPILE
- TA_DEV_KIT_DIR
- OPTEE_CLIENT_EXPORT

Acked-by: Jerome Forissier <jerome.forissier@linaro.org>
Acked-by: Yuan Zhuang <yuanz@apache.org>
Signed-off-by: Sumit Garg <sumit.garg@linaro.org>
@b49020
Copy link
Contributor Author

b49020 commented Jan 3, 2024

Thanks @DemesneGH, tag applied.

@jforissier jforissier merged commit 83fbbd3 into OP-TEE:master Jan 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants