Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Kubernetes image #76

Merged
merged 2 commits into from
Nov 5, 2021
Merged

Update Kubernetes image #76

merged 2 commits into from
Nov 5, 2021

Conversation

treydock
Copy link
Contributor

This pulls in some new OS packages that Shameema had me install for some newer versions of modules that will be needed to run those modules, I think mostly RStudio.

@treydock
Copy link
Contributor Author

Forgot to add that the image has been pre-pulled to all worker nodes in test and production clusters so there won't be a pod delay for first user to use each image on a node.

@johrstrom
Copy link
Contributor

I take it this needs to be released soon (today?).

@treydock
Copy link
Contributor Author

This might not be needed depending on if Shameema needs the new OS packages for new RStudio installs.

@treydock
Copy link
Contributor Author

treydock commented Oct 4, 2021

So I had to add a new bug fix to the images where the UID/GID of slurm user was incorrect, so the version now in this PR incorporates that bug fix. I think the incorrect UID/GID would likely just cause issues interacting with SLURM (ie submit job) from within the pod. That was at least the issue ZQ was having when using this image with Singularity.

Same change was made to OSC/bc_osc_rstudio_server#81

@johrstrom
Copy link
Contributor

So is this ready to be pulled in then?

@treydock
Copy link
Contributor Author

treydock commented Oct 4, 2021

Not yet, the image itself is still building (takes a couple hours) and I would like ZQ to verify the bug fix works for him. Once the image is built and ZQ verifies I would also need to pre-pull the image on worker nodes, but that can just be done before we tag a new release but will likely be done today I hope.

@treydock
Copy link
Contributor Author

treydock commented Oct 4, 2021

ZQ confirmed this latest image solved his problems, and I've pulled this latest image down to all Kubernetes worker nodes. So I think this and OSC/bc_osc_rstudio_server#81 are ready.

@johrstrom
Copy link
Contributor

cool, when do you want it released? ++@ZQyou

@ZQyou
Copy link
Contributor

ZQyou commented Oct 4, 2021

I am not using this image for classroom. It can be released anytime.

@johrstrom johrstrom merged commit e1489c0 into master Nov 5, 2021
@johrstrom johrstrom deleted the k8-image branch November 5, 2021 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants