Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a new peer-reviewed authority #4190

Closed
wants to merge 2 commits into from
Closed

Conversation

rouault
Copy link
Member

@rouault rouault commented Jul 6, 2024

Published in https://talks.osgeo.org/media/foss4g-europe-2024/submissions/B8CETX/resources/WGS_84_I_dont_know_I_dont_care_pTbpl9n.pdf, slides 37-38

Demo:

$ PROJ_DATA=data bin/projinfo IDNK:UTM_31N+IDNK:VERTICAL
PROJ.4 string:
+proj=utm +zone=31 +ellps=GRS80 +units=m +vunits=m +no_defs +type=crs

WKT2:2019 string:
COMPOUNDCRS["Unknown / UTM zone 31N + Unknown vertical CRS",
    PROJCRS["Unknown / UTM zone 31N",
        BASEGEOGCRS["Unknown geographic 2D CRS",
            DATUM["Unknown geodetic datum",
                ELLIPSOID["GRS 1980",6378137,298.257222101,
                    LENGTHUNIT["metre",1]]],
            PRIMEM["Greenwich",0,
                ANGLEUNIT["degree",0.0174532925199433]],
            ID["IDNK","GEOGRAPHIC"]],
        CONVERSION["UTM zone 31N",
            METHOD["Transverse Mercator",
                ID["EPSG",9807]],
            PARAMETER["Latitude of natural origin",0,
                ANGLEUNIT["degree",0.0174532925199433],
                ID["EPSG",8801]],
            PARAMETER["Longitude of natural origin",3,
                ANGLEUNIT["degree",0.0174532925199433],
                ID["EPSG",8802]],
            PARAMETER["Scale factor at natural origin",0.9996,
                SCALEUNIT["unity",1],
                ID["EPSG",8805]],
            PARAMETER["False easting",500000,
                LENGTHUNIT["metre",1],
                ID["EPSG",8806]],
            PARAMETER["False northing",0,
                LENGTHUNIT["metre",1],
                ID["EPSG",8807]]],
        CS[Cartesian,2],
            AXIS["(E)",east,
                ORDER[1],
                LENGTHUNIT["metre",1]],
            AXIS["(N)",north,
                ORDER[2],
                LENGTHUNIT["metre",1]],
        ID["IDNK","UTM_31N"]],
    VERTCRS["Unknown vertical CRS",
        VDATUM["Unknown vertical datum"],
        CS[vertical,1],
            AXIS["gravity-related height (H)",up,
                LENGTHUNIT["metre",1]],
        ID["IDNK","VERTICAL"]]]

@hobu
Copy link
Contributor

hobu commented Jul 6, 2024

peer-reviewed authority

I appreciate the fun easter egg, but it does bring up the topic of PROJ maintaining authorities. I thought project policy was to be not to do so given we have no way to upstream them to regularized standards bodies in a way that doesn't break their definition(s).

I understand the joke coming from @jjimenezshaw's talk, but I admit I'm a bit concerned that PROJ would be adding authorities. I see the PR is hiding it by masking it in the SQL queries, but TBH, I don't know if that's actually better. I'm not 👎 against the PR, but I think we as a project should state our stance on maintaining alternative definition authorities.

@rouault
Copy link
Member Author

rouault commented Jul 6, 2024

no problem if we don't end up merging this. This was done with an easter egg mood indeed

@kbevers
Copy link
Member

kbevers commented Jul 7, 2024

I share Howards sentiment. Although it is a fun easter egg it also adds unnecessary complexity to the code, so ultimately I am -1 on this PR.

@jjimenezshaw
Copy link
Contributor

I had no time yet to review the code (still in Estonia)
One option would be to use the PROJ authority, which is already hidden, right?

@rouault
Copy link
Member Author

rouault commented Jul 7, 2024

No the PROJ authority is not hidden

@rouault
Copy link
Member Author

rouault commented Jul 9, 2024

ok, let's close this

@rouault rouault closed this Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants