createOperation(): tune so that ITRF2000->ETRS89 does not return only NKG grid based operations but also time-dependent Helmert #4244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…(): avoid using intermediate CRS of ancient era when dealing with modern source/target CRS
rouault
force-pushed
the
ETRF2000_ETRS89
branch
from
219951b
to
631b2cb
Compare
rouault
changed the title
… NKG grid based operations but also time-dependent Helmert
rouault
force-pushed
the
ETRF2000_ETRS89
branch
from
631b2cb
to
529904c
Compare
|
I'd like to see examples of behaviour before and after this change. I think the changes looks sound but a bit of help to grasp the consequences would be appreciated. |
|
Forgot to mention this adresses https://lists.osgeo.org/pipermail/proj/2024-September/011494.html Before: only NKG transformations: After, also include ITRF2020 <--> ETRFxxxx time dependent Helmert transformations: The NKG ones should are still taken in their area of use since they have a lower value for the accuracy field Example in Estonia: |
|
Thanks. It does indeed look sound! |
kbevers
approved these changes
Sep 5, 2024
rouault
added a commit
to rouault/PROJ
that referenced
this pull request
Sep 17, 2024
…target CRS that have the same originating authority Fixes https://lists.osgeo.org/pipermail/proj/2024-September/011531.html i.e. ``` projinfo -s EPSG:4269 -t EPSG:6318 --3d --spatial-test intersects ``` The fix consists in making sure that we recognize that the 3d-promoted object EPSG:4269 (NAD83(86)) is still linked to EPSG, and thus discard ESRI 3D objects in findsOpsInRegistryWithIntermediate() Fixes a "regression" of OSGeo#4244 (one could argue which of the results is the best, given that NAD83(86) as a 3D geographic CRS has no solid foundation)
rouault
added a commit
to rouault/PROJ
that referenced
this pull request
Sep 17, 2024
…target CRS that have the same originating authority Fixes https://lists.osgeo.org/pipermail/proj/2024-September/011531.html i.e. ``` projinfo -s EPSG:4269 -t EPSG:6318 --3d --spatial-test intersects ``` The fix consists in making sure that we recognize that the 3d-promoted object EPSG:4269 (NAD83(86)) is still linked to EPSG, and thus discard ESRI 3D objects in findsOpsInRegistryWithIntermediate() Fixes a "regression" of OSGeo#4244 (one could argue which of the results is the best, given that NAD83(86) as a 3D geographic CRS has no solid foundation)
rouault
added a commit
to rouault/PROJ
that referenced
this pull request
Sep 17, 2024
…target CRS that have the same originating authority Fixes https://lists.osgeo.org/pipermail/proj/2024-September/011531.html i.e. ``` projinfo -s EPSG:4269 -t EPSG:6318 --3d --spatial-test intersects ``` The fix consists in making sure that we recognize that the 3d-promoted object EPSG:4269 (NAD83(86)) is still linked to EPSG, and thus discard ESRI 3D objects in findsOpsInRegistryWithIntermediate() Fixes a "regression" of OSGeo#4244 (one could argue which of the results is the best, given that NAD83(86) as a 3D geographic CRS has no solid foundation)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.