Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gdalwarp: fix crash/infinite loop when using -tr one a 1x1 blank raster (3.8.0 regression) #10822

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

rouault
Copy link
Member

@rouault rouault commented Sep 17, 2024

@coveralls
Copy link
Collaborator

coveralls commented Sep 17, 2024

Coverage Status

coverage: 69.372% (+0.001%) from 69.371%
when pulling 7f674a8 on rouault:fix_gdalwarp_one_one_blank_edge
into 2742d2b on OSGeo:master.

@misev
Copy link

misev commented Sep 17, 2024

I applied this commit to the release/3.8 branch and compiled it on Ubuntu 24.04 with cmake config

cmake ../gdal -DGDAL_BUILD_OPTIONAL_DRIVERS=OFF -DOGR_BUILD_OPTIONAL_DRIVERS=OFF

but it doesn't seem to work well:

$ export LD_LIBRARY_PATH="/usr/local/lib:$LD_LIBRARY_PATH"
$ ldd /usr/local/bin/gdalwarp 2>&1 | grep gdal -i
    libgdal.so.34 => /usr/local/lib/libgdal.so.34 (0x00007fc412c00000)
    
$ /usr/local/bin/gdalwarp test.vrt -t_srs EPSG:32631 -tr 1000 1000 -of VRT output.vrt -overwrite
Creating output file that is 0P x 0L.
ERROR 1: Attempt to create 0x0 dataset is illegal,sizes must be larger than zero.

@rouault rouault force-pushed the fix_gdalwarp_one_one_blank_edge branch from dffb61d to 7f674a8 Compare September 17, 2024 17:08
@rouault
Copy link
Member Author

rouault commented Sep 17, 2024

but it doesn't seem to work well:

I've updated the PR to also handle the case where -tap is not specified

@rouault rouault merged commit cde7a4d into OSGeo:master Sep 18, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

abort with gdalwarp and bad (too coarse) resolution
4 participants