cronjob: fix red new version box injection and script documentation

[neteler]

This PR modifies the way to inject the "Note: This document is for an older version of GRASS GIS ..." red boxes into the manual page. Now duplicate boxes should no longer show up.

(affects G78 and G83 core manual and related addon manual pages)

• https://grass.osgeo.org/grass78/manuals/
• https://grass.osgeo.org/grass78/manuals/addons/
• https://grass.osgeo.org/grass83/manuals/
• https://grass.osgeo.org/grass83/manuals/addons/

For testing purposes, this PR has been deployed on grass.osgeo.org (once this PR is merged the local update needs to be removed from server to re-enable cronjob-based GH pulls, tbd by MN).

Hint: Best is to check how the pages look like not before Aug 17th, 2024, in order to have several daily cronjob cycles done.

[veroandreo]

• https://grass.osgeo.org/grass78/manuals/ --> red box is now in the header and footer of all pages (index, group and indiv manuals)
• https://grass.osgeo.org/grass78/manuals/addons/ --> red box is in the header and footer in indiv pages (index looks fine)
• https://grass.osgeo.org/grass83/manuals/ --> red box is now in the header and footer of all pages (index, group and indiv manuals)
• https://grass.osgeo.org/grass83/manuals/addons/ --> red box is in the header and footer in indiv pages (index looks fine)

Was this always the case to have the red box in the footer too?

[wenzeslaus]

Can you please add a line or two describing what the commands are doing. Right now, the code is heavily write-only.

[neteler]

Was this always the case to have the red box in the footer too?

As I said: Best is to check how the pages look like not before Aug 17th, 2024, in order to have several daily cronjob cycles done.

[veroandreo]

Was this always the case to have the red box in the footer too?

As I said: Best is to check how the pages look like not before Aug 17th, 2024, in order to have several daily cronjob cycles done.

Oh, ok, I understood that the PR should be checked before that date... sorry for the noise then 🙏

[neteler]

Was this always the case to have the red box in the footer too?

No, it wasn't. In the overview pages the box was entirely missing.

Although I was surprised by the red box in the footer, on second thought it might not be so bad, especially for long pages. What do you think?

[veroandreo]

Was this always the case to have the red box in the footer too?

No, it wasn't. In the overview pages the box was entirely missing.

Although I was surprised by the red box in the footer, on second thought it might not be so bad, especially for long pages. What do you think?

I believe the one in the header is enough, no? That's the first thing one sees when opening a new page, and should be enough warning.

[echoix]

I saw some pages that had the header, but I stumbled upon one that only has a footer: https://grass.osgeo.org/grass83/manuals/variables.html

A page with header and footer: https://grass.osgeo.org/grass83/manuals/d.graph.html

[neteler]

Please re-check:

• https://grass.osgeo.org/grass83/manuals/
• https://grass.osgeo.org/grass83/manuals/addons/

I have uploaded a fix to the server. If ok, I'll submit it here and update this PR accordingly.

[veroandreo]

Please re-check:

• https://grass.osgeo.org/grass83/manuals/
• https://grass.osgeo.org/grass83/manuals/addons/

I have uploaded a fix to the server. If ok, I'll submit it here and update this PR accordingly.

looking good now!

[neteler]

Now also fixed (fix uploaded to the server for testing):

• https://grass.osgeo.org/grass78/manuals/
• https://grass.osgeo.org/grass78/manuals/addons/

[neteler]

Can you please add a line or two describing what the commands are doing. Right now, the code is heavily write-only.

Sure: improved documentation of scripts in

• edb3cfa (binary packages), and
• 54ee3cb (source code packages)

[neteler]

"Merging is blocked" - I'd like to move on here.

Is anything still missing?

[echoix]

"Merging is blocked" - I'd like to move on here.

Is anything still missing?

A requested changes by @wenzeslaus is still applied.

[neteler]

A requested changes by @wenzeslaus is still applied.

I seem to need a hint.

[wenzeslaus]

I agree with @echoix. I was indeed talking about documentation for the changed and complex lines. But I'm ready to move on here.

It is more beneficial just to move on.

[neteler]

A requested changes by @wenzeslaus is still applied.

Ok, see 1668170

[wenzeslaus]

Thanks!