Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

startup: catch errors in build_modules_xml.py, grass.py #2686

Merged
merged 2 commits into from
Feb 13, 2023

Conversation

neteler
Copy link
Member

@neteler neteler commented Dec 6, 2022

This PR is an extract from #348 (extracted and updated with black):

Not sure if we want these changes but just to avoid to see them lost when closing #348 in favour of #2684.

@neteler neteler added enhancement New feature or request Python Related code is in Python labels Dec 6, 2022
@neteler neteler added this to the 8.3.0 milestone Dec 6, 2022
Copy link
Member

@wenzeslaus wenzeslaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally, this looks good.

I'm not sure about managing these small changes smartly for the release notes. It does not fit into these categories:

https://github.com/OSGeo/grass/blob/main/utils/release.yml

lib/init/grass.py Outdated Show resolved Hide resolved
Co-authored-by: Vaclav Petras <wenzeslaus@gmail.com>
@neteler neteler changed the title build_modules_xml.py, grass.py: catch errors startup: catch errors in build_modules_xml.py, grass.py Jan 12, 2023
@neteler
Copy link
Member Author

neteler commented Jan 12, 2023

I'm not sure about managing these small changes smartly for the release notes.

I have changed to use the "startup: ..." keyword.

@neteler
Copy link
Member Author

neteler commented Jan 28, 2023

@wenzeslaus may I merge this PR? Not sure how to properly dismiss the "Changes requested" which I believe have been addressed.

@wenzeslaus
Copy link
Member

Dismiss review is in the details of the "change requested" section under the ... menu as Dismiss review which I think gives an option to say why it is no longer relevant. I agree that this is appropriate procedure for a small clearly defined change like this syntax fix, esp. with reviewer not revisiting the PR quickly.

The failure from Ubuntu / minimum config tests is unrelated to this PR (the old run cannot be restarted anymore).

@neteler neteler merged commit 20bba91 into OSGeo:main Feb 13, 2023
@neteler neteler deleted the python_scripterror_catch branch February 13, 2023 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Python Related code is in Python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants