-
-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
startup: catch errors in build_modules_xml.py, grass.py #2686
Conversation
This PR is an extract from OSGeo#348: - gui/wxpython/tools/build_modules_xml.py edits: https://github.com/OSGeo/grass/pull/348/files#diff-11ca77721b6d009b6537c54be4172efed843021797676258ad1141a6c63e6fd1 - lib/init/grass.py: https://github.com/OSGeo/grass/pull/348/files#diff-647be4ef599868c33f2f69f0d899f79f0aee8d75d1db74f523268c1ac94cddf7 Not sure if we want these changes but just to avoid to see them lost when closing OSGeo#348 in favour of OSGeo#2684.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally, this looks good.
I'm not sure about managing these small changes smartly for the release notes. It does not fit into these categories:
https://github.com/OSGeo/grass/blob/main/utils/release.yml
Co-authored-by: Vaclav Petras <wenzeslaus@gmail.com>
I have changed to use the "startup: ..." keyword. |
@wenzeslaus may I merge this PR? Not sure how to properly dismiss the "Changes requested" which I believe have been addressed. |
Dismiss review is in the details of the "change requested" section under the The failure from Ubuntu / minimum config tests is unrelated to this PR (the old run cannot be restarted anymore). |
* build_modules_xml.py, grass.py: catch errors This PR is an extract from OSGeo#348: - gui/wxpython/tools/build_modules_xml.py edits: https://github.com/OSGeo/grass/pull/348/files#diff-11ca77721b6d009b6537c54be4172efed843021797676258ad1141a6c63e6fd1 - lib/init/grass.py: https://github.com/OSGeo/grass/pull/348/files#diff-647be4ef599868c33f2f69f0d899f79f0aee8d75d1db74f523268c1ac94cddf7
* build_modules_xml.py, grass.py: catch errors This PR is an extract from OSGeo#348: - gui/wxpython/tools/build_modules_xml.py edits: https://github.com/OSGeo/grass/pull/348/files#diff-11ca77721b6d009b6537c54be4172efed843021797676258ad1141a6c63e6fd1 - lib/init/grass.py: https://github.com/OSGeo/grass/pull/348/files#diff-647be4ef599868c33f2f69f0d899f79f0aee8d75d1db74f523268c1ac94cddf7
This PR is an extract from #348 (extracted and updated with
black
):Not sure if we want these changes but just to avoid to see them lost when closing #348 in favour of #2684.