i.segment: Move unused variable value into a code comment #4153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenzeslaus
requested changes
Sep 16, 2024
There was a problem hiding this comment.
Just commenting this out creates ugly code, but I didn't dive into the code to be confident in just leaving this in the file history as opposed to having it in the code itself. There was no other feedback. Hence, I would just explicitly specify this in the code.
wenzeslaus
changed the title
wenzeslaus
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses the issue identified by coverity scan (CID : 1415633).
The variable hspec is getting overwritten and only last assigned value is being updated.
To resolve this, the redundant assignments have been commented out rather than removing completely.