lib/linkm: Change non-returning internal function types to void #4318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the internal functions had 'int' return type, but they were not returning anything and the places where these functions are called were also not expecting anything from the function. To, simplify such cases, change the function return type to 'void'. This was found using cppcheck tool. Signed-off-by: Mohan Yelugoti <ymdatta.work@gmail.com>
wenzeslaus
approved these changes
Sep 14, 2024
nilason
approved these changes
Sep 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the internal functions had
intreturn type, but they were not returning anything and the places where these functions are called were also not expecting anything from the function.To, simplify such cases, change the function return type to 'void'.
This issue was found using cppcheck tool. It's a low-priority one, since it's in the tests and the functions affected are internal test functions.
Additional information:
Output from cppcheck after the fix