v.in.dwg: Retire v.in.dwg infavor of v.in.redwg #4329
Conversation
ymdatta
force-pushed
the
retire_vindwg
branch
from
17184b8
to
8984f57
Compare
|
You also need to remove the entry in the Makefile of the parent folder, Line 105 in 95c123d |
ymdatta
force-pushed
the
retire_vindwg
branch
from
8984f57
to
87cf4e3
Compare
github-actions
bot
added
vector
There was a problem hiding this comment.
Hm, this is even more complicated. Changes in configure.ac include/Make/Platform.make.in are needed. @ymdatta please do that and regenerate configure if you feel up to it or open an issue for it (and we merge this PR without the change).
|
Why not rename v.in.redwg as v.in.dwg and v.in.dwg as v.in.opendwg? The end user doesn't care what the backend library is, only that the name is self-documenting and it does what they want it to. best, |
Yes, that's possible. v.in.redwg is currently in grass-addons, so it an independent discussion from this PR and may include discussion about moving it to the core (perhaps you want to open a GitHub Discussion or grass-dev thread for that). v.in.opendwg is not bad in general, but I don't see someone actually maintaining the code, so keeping in active code base (in core or addons) does not seem good. |
|
Renaming a module is kinda disruptive for anyone having scripted workflows. If the backend library changes, (thus keeping this module), and has somewhat a similar behavior as before, why would we need to rename the module? It's reasonable to say like : this module now uses a new library, and might have some differences, but is more recent/accepts newer files types Rather than: oh oh, that module doesn't exist anymore at all, change to use that same module with another name and library. |
v.in.dwg is linked to proprietary library 'OpenDWG toolkit'. One needs to become a member of OpenDWG Alliance to get the needed libraries and headers in order to compile this module. However, OpenDWG webpage went offline around 2011 and we have 'v.in.redwg' as replacement for it. Hence retire 'v.in.dwg' module. Modify configure.ac and platform make to remove any remnants of opendwg in them. Signed-off-by: Mohan Yelugoti <ymdatta.work@gmail.com>
ymdatta
force-pushed
the
retire_vindwg
branch
from
87cf4e3
to
23c5263
Compare
|
@wenzeslaus : Made the necessary changes.
Minor testing done: able to configure with current configuration and compile without any issues. When configure was run, didn't see any indication of dwg in the support section of config. Earlier: (Indicated with asteriks around, Line 5) After the change: |
v.in.dwg is linked to proprietary library 'OpenDWG toolkit'. One needs to become a member of OpenDWG Alliance to get the needed libraries and headers in order to compile this module.
However, OpenDWG webpage went offline around 2011 and we have 'v.in.redwg' as replacement for it. Hence retire 'v.in.dwg' module.