Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.drop to .drop_vars #1364

Merged
merged 3 commits into from
Jul 23, 2024
Merged

.drop to .drop_vars #1364

merged 3 commits into from
Jul 23, 2024

Conversation

ctuguinay
Copy link
Collaborator

Fixes part of #1309

@ctuguinay ctuguinay added the dependencies Anything related to dependencies label Jul 23, 2024
@ctuguinay ctuguinay self-assigned this Jul 23, 2024
@ctuguinay ctuguinay added this to the v0.9.0 milestone Jul 23, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jul 23, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 89.52%. Comparing base (9f56124) to head (1f02cfe).
Report is 131 commits behind head on main.

Files Patch % Lines
echopype/calibrate/range.py 33.33% 2 Missing ⚠️
echopype/calibrate/calibrate_ek.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1364      +/-   ##
==========================================
+ Coverage   83.52%   89.52%   +6.00%     
==========================================
  Files          64       11      -53     
  Lines        5686     1002    -4684     
==========================================
- Hits         4749      897    -3852     
+ Misses        937      105     -832     
Flag Coverage Δ
unittests 89.52% <50.00%> (+6.00%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ctuguinay ctuguinay marked this pull request as ready for review July 23, 2024 02:54
@ctuguinay ctuguinay requested a review from leewujung July 23, 2024 02:54
@ctuguinay
Copy link
Collaborator Author

@leewujung This is ready to review. It fixes a part of #1309.

Copy link
Member

@leewujung leewujung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ctuguinay , LGTM!

@ctuguinay ctuguinay merged commit f9c1b27 into OSOceanAcoustics:main Jul 23, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Anything related to dependencies
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants