Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add securityContext for exporter, initcontainers and sidecars #987

Merged
merged 6 commits into from
Jun 15, 2024
Merged

Conversation

lsoica
Copy link
Contributor

@lsoica lsoica commented Jun 14, 2024

Description

Fixes #978

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • Tests have been added/modified and all tests pass.
  • Functionality/bugs have been confirmed to be unchanged or fixed.
  • I have performed a self-review of my own code.
  • Documentation has been updated or added where necessary.

Signed-off-by: laurentiusoica <laurentiu.soica@spirent.com>
Signed-off-by: laurentiusoica <laurentiu.soica@spirent.com>
Signed-off-by: laurentiusoica <laurentiu.soica@spirent.com>
Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.63%. Comparing base (d121d86) to head (70e65f7).
Report is 69 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #987      +/-   ##
==========================================
+ Coverage   35.20%   44.63%   +9.43%     
==========================================
  Files          19       20       +1     
  Lines        3213     2693     -520     
==========================================
+ Hits         1131     1202      +71     
+ Misses       2015     1418     -597     
- Partials       67       73       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@drivebyer drivebyer self-requested a review June 14, 2024 14:06
api/v1beta2/common_types.go Outdated Show resolved Hide resolved
Signed-off-by: laurentiusoica <laurentiu.soica@spirent.com>
Signed-off-by: laurentiusoica <laurentiu.soica@spirent.com>
Signed-off-by: laurentiusoica <laurentiu.soica@spirent.com>
@lsoica lsoica requested a review from drivebyer June 15, 2024 08:22
@drivebyer drivebyer enabled auto-merge (squash) June 15, 2024 09:02
@drivebyer drivebyer merged commit a838608 into OT-CONTAINER-KIT:master Jun 15, 2024
29 checks passed
mattrobinsonsre pushed a commit to mattrobinsonsre/redis-operator that referenced this pull request Jul 11, 2024
…T-CONTAINER-KIT#987)

* feat: add securityContext for exporter, initcontainers and sidecars

Signed-off-by: laurentiusoica <laurentiu.soica@spirent.com>

* fix: add docs

Signed-off-by: laurentiusoica <laurentiu.soica@spirent.com>

* fix: RedisExporterSecurityContext instead of SecurityContext

Signed-off-by: laurentiusoica <laurentiu.soica@spirent.com>

* fix: code review

Signed-off-by: laurentiusoica <laurentiu.soica@spirent.com>

* fix: refresh crds

Signed-off-by: laurentiusoica <laurentiu.soica@spirent.com>

* fix: refresh crds

Signed-off-by: laurentiusoica <laurentiu.soica@spirent.com>

---------

Signed-off-by: laurentiusoica <laurentiu.soica@spirent.com>
Co-authored-by: laurentiusoica <laurentiu.soica@spirent.com>
Signed-off-by: Matt Robinson <mattrobinsonsre@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't apply containerSecurityContext to other containers than redis
3 participants