Merge pull request #12 from OakvilleDynamics/bugfix/swerve-values #40
garrettsummerfi3ldAnnotations
6 warnings
|
qodana
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: JetBrains/qodana-action@v2023.3.1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
Pointless boolean expression:
src/main/java/frc/robot/commands/IntakeCommand.java#L28
`IntakeJoystick.getRawButton(3) == true` can be simplified to 'IntakeJoystick.getRawButton(3)'
|
|
Pointless boolean expression:
src/main/java/frc/robot/commands/IntakeCommand.java#L31
`IntakeJoystick.getRawButton(4) == true` can be simplified to 'IntakeJoystick.getRawButton(4)'
|
|
Pointless boolean expression:
src/main/java/frc/robot/commands/ConveyorCommand.java#L31
`ConveyorJoystick.getRawButton(4) == true` can be simplified to 'ConveyorJoystick.getRawButton(4)'
|
|
Pointless boolean expression:
src/main/java/frc/robot/commands/ConveyorCommand.java#L28
`ConveyorJoystick.getRawButton(3) == true` can be simplified to 'ConveyorJoystick.getRawButton(3)'
|
|
Simplifiable conditional expression:
src/main/java/frc/robot/subsystems/swervedrive/SwerveSubsystem.java#L124
`alliance.isPresent() ? alliance.get() == DriverStation.Alliance.Red : false` can be simplified to 'alliance.isPresent() \&\& alliance.get() == DriverStation.Alliance.Red'
|