Add AdvantageKit, REV Spark MAX logging #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added AdvantageKit for extra diagnostics and logging for the robot. This will help hook into the AdvantageScope tool for WPILib. Added a Git metadata information task for each Gradle build, such as the commit SHA, the date of the build, the branch, and if the build was dirty (has changes not committed). This requires the installation of the Git CLI and be available on the PATH. Fixed issue where formatting failed a build. This will now perform the formatting on all builds, including deploy jobs.
Since REV does not provide an official method of automatically recording data from the Spark Max and Spark Flex, we have provided an unofficial alternative for Java and C++ called URCL (Unofficial REV-Compatible Logger). This enables live plotting and logging of all devices similar to CTRE's Tuner X plotting feature and Phoenix 6 signal logger. Power Distribution Hub is also now logged in AdvantageKit.
garrettsummerfi3ld
requested review from
ShaneHopkins11,
EuphoniumPlayer and
Kendialouge
EuphoniumPlayer
approved these changes
Feb 16, 2024
EuphoniumPlayer
requested changes
Feb 16, 2024
Fixed an issue where if not provided a log of a match during robot simulation, the software would crash. This now is handled with just running the simulation as normal without a replay. There is no current logic for how to feed information into the simulator at the moment. Added metadata for robot software. This includes runtime type such as a simulation or a real robot, as well as Git information such as the commit SHA, the build date, the commit date, branch, and whether or not if there are files not committed to the repository.
garrettsummerfi3ld
added
the
dependencies
Updated AdvantageKit from 3.0.2 to 3.1.0 Updated URCL from 2024.0.1 to 2024.1.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
Added AdvantageKit for extra diagnostics and logging for the robot. This will help hook into the AdvantageScope tool for WPILib.
Added a Git metadata information task for each Gradle build, such as the commit SHA, the date of the build, the branch, and if the build was dirty (has changes not committed). This requires the installation of the Git CLI and be available on the systems or users
PATH.Since REV does not provide an official method of automatically recording data from the Spark Max and Spark Flex, we have provided an unofficial alternative for Java and C++ called URCL (Unofficial REV-Compatible Logger). This enables live plotting and logging of all devices similar to CTRE's Tuner X plotting feature and Phoenix 6 signal logger.
Fixed
Fixed issue where formatting failed a build. This will now perform the formatting on all builds, including deploy jobs.
Changed
Changed around some of the
Constantsof CAN IDs to just point to a newHardwareConstantsclass rather than having subclasses for each "subsystem."