Fix PnuematicNumbers, Created Elevator #28

DLipovac93 · 2024-03-11T02:15:18Z

tweaked the numbers for the pnuematics on the REVPH since they were changed today, also created controls and subsystem for the elevator. Please double check me since I probably screwed up somewhere

garrettsummerfi3ld

Fix the issue causing build error and it's all good to go. Just need the missing semicolon.

src/main/java/frc/robot/subsystems/Elevator.java

tweaked the numbers for the pnuematics on the REVPH since they were changed today, also created controls and subsystem for the elevator. Please double check me since I probably screwed up somewhere

added missing semicolen, also removed a unessiary line. *my spelling sucks

garrettsummerfi3ld · 2024-03-11T07:11:23Z

src/main/java/frc/robot/subsystems/Elevator.java

+public void close() {
+    doubleSolenoid.set(DoubleSolenoid.Value.kReverse);
+    SmartDashboard.putBoolean(getName(), false);
+}


Need a final } at the end of the file.

Didn't see this first time around.

garrettsummerfi3ld

Last minute updates to the code issues.

garrettsummerfi3ld · 2024-03-11T07:16:44Z

src/main/java/frc/robot/subsystems/Elevator.java

+          ElevatorConstants.OUT);
+
+ /** Create new pnuematic system */
+    public elevator() {


Rename constructor from elevator() to Elevator(). Should fix the build issues.

garrettsummerfi3ld

You should also add this to your RobotContainer.java, similar to how Dump is configured in the file.

  public RobotContainer() {

    intake.setDefaultCommand(new IntakeCommand(intake));
    dump.setDefaultCommand(new DumpControl(dump));
    conveyor.setDefaultCommand(new ConveyorCommand(conveyor));
    flyWheel.setDefaultCommand(new FlyWCommand(flyWheel));

garrettsummerfi3ld · 2024-03-11T07:18:23Z

src/main/java/frc/robot/subsystems/Elevator.java

+import frc.robot.Constants.PneumaticsConstants.ElevatorConstants;
+import frc.robot.util.Time;
+
+public class Elevator {


This should also have extends SubsystemBase for the class, looking like:

public class Elevator extends SubsystemBase {

DLipovac93 · 2024-03-11T16:35:31Z

Build still fails, even after changing all of that

Fixed all of the redlines, not sure if it works as the bot is in multiple pieces at the time of this commit being made.

More fixed, still not tested as of the time of committing

…ynamics/2024-Robot into Elevator/PnuematicsFix

garrettsummerfi3ld · 2024-03-11T20:44:19Z

@EuphoniumPlayer @DLipovac93 builds still failing, are you looking at what is causing it to fail builds? It looks like you are assigning incorrect classes to each other.

EuphoniumPlayer · 2024-03-11T21:34:27Z

@garrettsummerfi3ld It built for me

commit 3767375 Author: EuphoniumPlayer <chasewmanzella@gmail.com> Date: Sun Mar 10 12:40:05 2024 -0500 Attempt to fix Conveyor Direction REQUIRES TESTING, IF IT DOES NOT WORK CHANGE CONVEYOR_MOTOR_1_INVERTED BACK TO TRUE AND 2 BACK TO FALSE commit 5f8df64 Author: OakvilleDynamicsProgramer <159196208+OakvilleDynamicsProgrammer@users.noreply.github.com> Date: Fri Mar 8 18:04:01 2024 -0600 Fixed Conveyor Direction STILL NEEDS REVIEW WITH BOTH BELTS FUNCTIONAL! But it seems that the problem is fixed. commit a35a082 Author: OakvilleDynamicsProgramer <159196208+OakvilleDynamicsProgrammer@users.noreply.github.com> Date: Fri Mar 8 17:55:44 2024 -0600 Fixed Dump Dump commands were flipped (fixed), openThenClose starts death spiral that disables the bot. As a result, openThenClose has been abandoned for the time being. commit d1c991a Author: EuphoniumPlayer <chasewmanzella@gmail.com> Date: Thu Mar 7 21:34:02 2024 -0600 Fixed a POV Value Typo "FlyWJoystick.getPOV() == >>>215<<<" has been corrected to "FlyWJoystick.getPOV() == >>>315<<<" in FlyWCommand.java. Additionally, some completed //TODO's have been cleared due to completion of their task in previous commits. commit 3c9240e Author: EuphoniumPlayer <chasewmanzella@gmail.com> Date: Thu Mar 7 17:36:07 2024 -0600 Implement full speed Full speed (100%) is now default forward POV speed (not 65%). To go 65% speed, press button 12. commit 100b174 Author: EuphoniumPlayer <chasewmanzella@gmail.com> Date: Tue Mar 5 20:14:59 2024 -0600 Flywheels remapped Upwards to the 45s and center is temporarily set to reduced speed until they clear to go full/adjusted speed. Downwards is 15% speed (center and 45s). Button 7 is reverse (reverse is set to 15% speed). commit bb11261 Merge: 43ecc28 624c997 Author: EuphoniumPlayer <chasewmanzella@gmail.com> Date: Tue Mar 5 19:59:54 2024 -0600 Updated Remap commit 43ecc28 Author: EuphoniumPlayer <chasewmanzella@gmail.com> Date: Tue Mar 5 19:19:29 2024 -0600 Renamed Joystick for Clarity Matched the name of the joystick in the FlyWCommand class to match the pattern found within all other Command classes. commit bef3f91 Author: EuphoniumPlayer <chasewmanzella@gmail.com> Date: Tue Mar 5 19:14:04 2024 -0600 Buttons remapped All buttons for intake control have been remapped as suggested by Andrew. commit 29b49bd Merge: e5c8162 32b7e6d Author: EuphoniumPlayer <chasewmanzella@gmail.com> Date: Tue Mar 5 17:46:00 2024 -0600 Merge branch 'Temporary-copy-to-add-flywheels-to-remap' into remap-intake-buttons commit e5c8162 Author: OakvilleDynamicsProgrammer <chasewmanzella@gmail.com> Date: Tue Mar 5 15:56:03 2024 -0600 Buttons remapped The intake commands for the sushi rollers and the front rollers have been split up and assigned to different buttons. Sushi in: 5, Sushi out: 6, Front in, 3, Front out: 4. The conveyor runs in the appropriate direction for each button (5 & 3 in, 3 & 4 out).

Elevator control systems still need to be implemented, but the control values have been implemented

Made the action names for moving the bot "up" and "down" instead of "open" and "closed"

garrettsummerfi3ld · 2024-03-12T00:58:25Z

Side note @EuphoniumPlayer, squash commits such as c93b010 needs to not happen as often if at all. This commit really makes the git history impossible to diagnose now because changes in these commits are not tracked because they are squashed into one, and thus half the changes here don't make sense on what was worked on since not only they don't pertain the original intention of the branch, but everything else looks messy.

DLipovac93 requested a review from garrettsummerfi3ld as a code owner March 11, 2024 02:15

garrettsummerfi3ld requested changes Mar 11, 2024

View reviewed changes

src/main/java/frc/robot/subsystems/Elevator.java Outdated Show resolved Hide resolved

DLipovac93 added 2 commits March 10, 2024 21:14

Fix PnuematicNumbers, Created Elevator

8e3703c

tweaked the numbers for the pnuematics on the REVPH since they were changed today, also created controls and subsystem for the elevator. Please double check me since I probably screwed up somewhere

added semicolen, and others

9637fe5

added missing semicolen, also removed a unessiary line. *my spelling sucks

garrettsummerfi3ld self-requested a review March 11, 2024 06:58

garrettsummerfi3ld requested changes Mar 11, 2024

View reviewed changes

garrettsummerfi3ld reviewed Mar 11, 2024

View reviewed changes

garrettsummerfi3ld assigned DLipovac93 Mar 11, 2024

added elevator stuff to Robot Container

c30254f

EuphoniumPlayer and others added 4 commits March 11, 2024 15:25

Fixed Red Lines

9dc2ba2

Fixed all of the redlines, not sure if it works as the bot is in multiple pieces at the time of this commit being made.

[Spotless] Apply formatting

8f176ec

Fixed Additional Redlines

badab7c

More fixed, still not tested as of the time of committing

Merge branch 'Elevator/PnuematicsFix' of https://github.com/OakvilleD…

be40ec7

…ynamics/2024-Robot into Elevator/PnuematicsFix

DLipovac93 and others added 2 commits March 11, 2024 14:20

FIxing constants and adding things,

acb27d4

[Spotless] Apply formatting

4e1e667

EuphoniumPlayer added 3 commits March 11, 2024 16:35

Added elevator controls

89a1899

Elevator control systems still need to be implemented, but the control values have been implemented

Sensible names

a3f9d38

Made the action names for moving the bot "up" and "down" instead of "open" and "closed"

garrettsummerfi3ld self-requested a review March 11, 2024 22:00

Updated Elevator Control #'s

20c3412

garrettsummerfi3ld approved these changes Mar 12, 2024

View reviewed changes

garrettsummerfi3ld merged commit d0bee59 into main Mar 12, 2024
7 checks passed

garrettsummerfi3ld deleted the Elevator/PnuematicsFix branch March 12, 2024 01:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix PnuematicNumbers, Created Elevator #28

Fix PnuematicNumbers, Created Elevator #28

DLipovac93 commented Mar 11, 2024

garrettsummerfi3ld left a comment

garrettsummerfi3ld Mar 11, 2024

garrettsummerfi3ld left a comment

garrettsummerfi3ld Mar 11, 2024

garrettsummerfi3ld left a comment

garrettsummerfi3ld Mar 11, 2024

DLipovac93 commented Mar 11, 2024

garrettsummerfi3ld commented Mar 11, 2024

EuphoniumPlayer commented Mar 11, 2024

garrettsummerfi3ld commented Mar 12, 2024 •

edited

Loading

Fix PnuematicNumbers, Created Elevator #28

Fix PnuematicNumbers, Created Elevator #28

Conversation

DLipovac93 commented Mar 11, 2024

garrettsummerfi3ld left a comment

Choose a reason for hiding this comment

garrettsummerfi3ld Mar 11, 2024

Choose a reason for hiding this comment

garrettsummerfi3ld left a comment

Choose a reason for hiding this comment

garrettsummerfi3ld Mar 11, 2024

Choose a reason for hiding this comment

garrettsummerfi3ld left a comment

Choose a reason for hiding this comment

garrettsummerfi3ld Mar 11, 2024

Choose a reason for hiding this comment

DLipovac93 commented Mar 11, 2024

garrettsummerfi3ld commented Mar 11, 2024

EuphoniumPlayer commented Mar 11, 2024

garrettsummerfi3ld commented Mar 12, 2024 • edited Loading

garrettsummerfi3ld commented Mar 12, 2024 •

edited

Loading