Remapped Buttons Finalization #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The intake commands for the sushi rollers and the front rollers have been split up and assigned to different buttons. Sushi in: 5, Sushi out: 6, Front in, 3, Front out: 4. The conveyor runs in the appropriate direction for each button (5 & 3 in, 3 & 4 out).
All buttons for intake control have been remapped as suggested by Andrew.
Matched the name of the joystick in the FlyWCommand class to match the pattern found within all other Command classes.
Upwards to the 45s and center is temporarily set to reduced speed until they clear to go full/adjusted speed. Downwards is 15% speed (center and 45s). Button 7 is reverse (reverse is set to 15% speed).
Full speed (100%) is now default forward POV speed (not 65%). To go 65% speed, press button 12.
Typo "FlyWJoystick.getPOV() == >>>215<<<" has been corrected to "FlyWJoystick.getPOV() == >>>315<<<" in FlyWCommand.java. Additionally, some completed //TODO's have been cleared due to completion of their task in previous commits.
Dump commands were flipped (fixed), openThenClose starts death spiral that disables the bot. As a result, openThenClose has been abandoned for the time being.
STILL NEEDS REVIEW WITH BOTH BELTS FUNCTIONAL! But it seems that the problem is fixed.
REQUIRES TESTING, IF IT DOES NOT WORK CHANGE CONVEYOR_MOTOR_1_INVERTED BACK TO TRUE AND 2 BACK TO FALSE
Added backup buttons for elevator control in the event that the throttle does not trigger actions correctly
Kinda useless
Removed a TODO and an empty space
Reformatted to make the if (true)'s less lengthy and messy. Additionally, the fly wheels now reverse from button 11 AND 7 (pulled it closer). One more thing, the conveyor can now be controlled separately from other parts of the intake by using button 9 to reverse it and button 10 to advance it.
EuphoniumPlayer
changed the title
garrettsummerfi3ld
approved these changes
Mar 12, 2024
There was a problem hiding this comment.
Comments are helpful, however it should only be noted as what the function does in reference to the function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Known Functionality:
Button 1 (trigger) dumps,
button 2 (thumb button) closes the dump bed,
button 3 moves the front and conveyor inward,
button 4 moves the front and conveyor out,
button 5 moves the sushi roller and conveyor in,
button 6 moves the sushi rollers and conveyor out,
button 7 is one of the flywheel reverse buttons,
button 8 has no functionality,
button 9 moves the conveyor backwards,
button 10 moves the conveyor forwards,
button 11 reverses the flywheels (exact same function as button 7)
button 12 moves the flywheels forward at 65% speed.
POV forward and to either of the forward 45's moves the flywheels forward at 100% speed,
POV backward and to either of the backward 45's moves the flywheels forward at 15% speed,
POV to either side does nothing.
Requires Testing:
Throttle + activates the elevator (will lift),
Throttle - deactivates the elevator (will lower),
Throttle middle maintains last action (in theory).