-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed autos #37
fixed autos #37
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure the commands are being hooked up properly for the autonomous paths.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this need to be a command? Dump should already have some command you can hook into.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this need to be a command? Conveyor should already have some command you can hook into.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this need to be a command? Flywheel should already have some command you can hook into.
@@ -6,6 +6,7 @@ | |||
|
|||
import com.revrobotics.CANSparkLowLevel; | |||
import com.revrobotics.CANSparkMax; | |||
import edu.wpi.first.wpilibj2.command.Command; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Subsystems and commands should be separate.
|
||
public Command shootCommand() { | ||
// TODO Auto-generated method stub | ||
throw new UnsupportedOperationException("Unimplemented method 'shootCommand'"); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Subsystems and commands should be separate.
@@ -6,6 +6,7 @@ | |||
|
|||
import com.revrobotics.CANSparkLowLevel; | |||
import com.revrobotics.CANSparkMax; | |||
import edu.wpi.first.wpilibj2.command.Command; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Subsystems and commands should be separate.
/** Sets the flywheel motors to 100% power. */ | ||
public void enableflywheelfull() { | ||
/** | ||
* Sets the flywheel motors to 100% power. | ||
* | ||
* @return | ||
*/ | ||
public Command enableflywheelfull() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Subsystems and commands should be separate.
|
||
public Object shootCommand() { | ||
// TODO Auto-generated method stub | ||
throw new UnsupportedOperationException("Unimplemented method 'shootCommand'"); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commands shouldn't be objects.
No description provided.