Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed autos #37

Merged
merged 5 commits into from
Mar 21, 2024
Merged

fixed autos #37

merged 5 commits into from
Mar 21, 2024

Conversation

ShaneHopkins11
Copy link
Contributor

No description provided.

Copy link
Member

@garrettsummerfi3ld garrettsummerfi3ld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure the commands are being hooked up properly for the autonomous paths.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to be a command? Dump should already have some command you can hook into.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to be a command? Conveyor should already have some command you can hook into.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to be a command? Flywheel should already have some command you can hook into.

@@ -6,6 +6,7 @@

import com.revrobotics.CANSparkLowLevel;
import com.revrobotics.CANSparkMax;
import edu.wpi.first.wpilibj2.command.Command;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Subsystems and commands should be separate.

Comment on lines +48 to +52

public Command shootCommand() {
// TODO Auto-generated method stub
throw new UnsupportedOperationException("Unimplemented method 'shootCommand'");
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Subsystems and commands should be separate.

@@ -6,6 +6,7 @@

import com.revrobotics.CANSparkLowLevel;
import com.revrobotics.CANSparkMax;
import edu.wpi.first.wpilibj2.command.Command;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Subsystems and commands should be separate.

Comment on lines 25 to 31
/** Sets the flywheel motors to 100% power. */
public void enableflywheelfull() {
/**
* Sets the flywheel motors to 100% power.
*
* @return
*/
public Command enableflywheelfull() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Subsystems and commands should be separate.

Comment on lines +64 to +68

public Object shootCommand() {
// TODO Auto-generated method stub
throw new UnsupportedOperationException("Unimplemented method 'shootCommand'");
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commands shouldn't be objects.

@garrettsummerfi3ld garrettsummerfi3ld merged commit 5e2a24a into main Mar 21, 2024
7 checks passed
@garrettsummerfi3ld garrettsummerfi3ld deleted the new-autopaths branch March 21, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants