Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#113 Improve support for non-string ID columns #116

Merged
merged 2 commits into from
Aug 20, 2020

Conversation

tunger
Copy link
Contributor

@tunger tunger commented Jul 15, 2020

This is an attempt to improve support for non-string ID columns as stated in #113.

Main changes (which need to be discussed):

  • Change Load signatures to use object
  • [breaking] Seperate Load methods which load multiple documents to LoadMany. Change signature to object[] or params object[] because IEnumerable<object> doesn't work for any type.

Please let me know if this is something you approve, or if we should solve this another way.

@tunger
Copy link
Contributor Author

tunger commented Jul 17, 2020

Alternative would be to create overloads for common key-types like Guid, int, long, string.

@tunger
Copy link
Contributor Author

tunger commented Jul 19, 2020

I added tons of overloads for string, int, long and Guid as overloads for the various Load methods, and dropped object. Should be easier to use now.

@PaulStovell PaulStovell merged commit 8c2052e into OctopusDeploy:master Aug 20, 2020
@PaulStovell
Copy link
Member

I think you found a really elegant solution here - nice one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants