Add SQL Error Code 10936 to list of transient error codes #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We (Cloud Platform) are frequently hitting the following error/exception when executing our E2E tests which utilise a SQL Azure Elastic Pool.
SQL Error 10936 - Resource ID : %d. The request limit for the elastic pool is %d and has been reached.There is little information on this specific error code available although there is an open PR on the Azure Docs repo for this to be documented.
This PR adds this specific error code to the list of
SimpleTransientErrorCodesEF Core treats this as a transient error and as such I would expect this to be a safe addition to Nevermore.
It is worth noting that the list of transient error codes in EF Core (where these were originally sourced from based on code comments) now includes a number of additional codes not reflected in Nevermore. I'm happy to submit another PR to update this if this would be preferred?