Skip to content

Commit

Permalink
rocksdb feature flag (#136)
Browse files Browse the repository at this point in the history
* remove `rocksdb` from dependencies

Signed-off-by: muraca <mmuraca247@gmail.com>

* added Database section to README.md

Signed-off-by: muraca <mmuraca247@gmail.com>

* `rocksdb` feature flag

Signed-off-by: muraca <mmuraca247@gmail.com>
  • Loading branch information
muraca committed Nov 9, 2023
1 parent a55975d commit 76bc8b1
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 2 deletions.
4 changes: 2 additions & 2 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ substrate-wasm-builder = { git = "https://github.com/paritytech/polkadot-sdk", t
# Substrate primitives and client
sc-basic-authorship = { git = "https://github.com/paritytech/polkadot-sdk", tag = "polkadot-v1.2.0" }
sc-chain-spec = { git = "https://github.com/paritytech/polkadot-sdk", tag = "polkadot-v1.2.0" }
sc-cli = { git = "https://github.com/paritytech/polkadot-sdk", tag = "polkadot-v1.2.0" }
sc-cli = { default-features = false, git = "https://github.com/paritytech/polkadot-sdk", tag = "polkadot-v1.2.0" }
sc-client-api = { git = "https://github.com/paritytech/polkadot-sdk", tag = "polkadot-v1.2.0" }
sc-consensus = { git = "https://github.com/paritytech/polkadot-sdk", tag = "polkadot-v1.2.0" }
sc-consensus-aura = { git = "https://github.com/paritytech/polkadot-sdk", tag = "polkadot-v1.2.0" }
Expand All @@ -67,7 +67,7 @@ sc-keystore = { git = "https://github.com/paritytech/polkadot-sdk", tag = "polka
sc-network = { git = "https://github.com/paritytech/polkadot-sdk", tag = "polkadot-v1.2.0" }
sc-rpc = { git = "https://github.com/paritytech/polkadot-sdk", tag = "polkadot-v1.2.0" }
sc-rpc-api = { git = "https://github.com/paritytech/polkadot-sdk", tag = "polkadot-v1.2.0" }
sc-service = { git = "https://github.com/paritytech/polkadot-sdk", tag = "polkadot-v1.2.0" }
sc-service = { default-features = false, git = "https://github.com/paritytech/polkadot-sdk", tag = "polkadot-v1.2.0" }
sc-telemetry = { git = "https://github.com/paritytech/polkadot-sdk", tag = "polkadot-v1.2.0" }
sc-transaction-pool = { git = "https://github.com/paritytech/polkadot-sdk", tag = "polkadot-v1.2.0" }
sc-transaction-pool-api = { git = "https://github.com/paritytech/polkadot-sdk", tag = "polkadot-v1.2.0" }
Expand Down
6 changes: 6 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,12 @@ The best way to explore this runtime is by browsing its [code](./tuxedo-template

There is an example node built with the Tuxedo template runtime. Because Tuxedo is primarily a runtime development framework, there is not much interesting or unique to Tuxedo to see in this crate. It is mostly a copy from the popular [Substrate node template](https://github.com/substrate-developer-hub/substrate-node-template/tree/main/node).

#### Database

PR [#136](https://github.com/Off-Narrative-Labs/Tuxedo/pull/136) set ParityDB as the default database instead of RocksDB.
This choice is unopinionated, it was made simply because RocksDB takes longer time to compile and adds unnecessary dependencies for our current use case.
Developers are free to use RocksDB instead by building the node with the feature flag `rocksdb`.

### Wallet

The repo contains a CLI cryptocurrency wallet that works with the template node in the `wallet` directory.
Expand Down
1 change: 1 addition & 0 deletions node/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -55,3 +55,4 @@ substrate-build-script-utils = { workspace = true }

[features]
default = []
rocksdb = [ "sc-cli/rocksdb", "sc-service/rocksdb" ]

0 comments on commit 76bc8b1

Please sign in to comment.