-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs directory restructure: Partials, images, third-party docs #1247
base: master
Are you sure you want to change the base?
Conversation
Deployment failed with the following error:
Learn More: https://vercel.link/invalid-route-destination-segment |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…arbitrum-docs into file-restructure-6
"permanent": false | ||
}, | ||
{ | ||
"source": "/for-devs/third-party-docs/:slug*", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @TucksonDev - what I referred to in chat
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, that's very nice! 🔥
Is it possible to add the /?
at the end? It's not critical, imo, but the current links have a /
at the end, and fail to redirect if we add that (e.g. https://arbitrum-docs-git-file-restructure-6-offchain-labs.vercel.app/for-devs/third-party-docs/Envio/
).
</a> | ||
. | ||
</p> | ||
<p>Yes! Arbitrum Orbit's core technology has undergone a comprehensive audit and is now able to support deployments to mainnet. You can read more about it <a href="https://docs.arbitrum.io/launch-orbit-chain/concepts/public-preview-expectations#arbitrum-orbit-is-mainnet-ready-but-deploy-to-testnet-first">here</a>.</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you run yarn format
one more time to remove these changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing job, sir! 🚀
I've left 2 minor comments, but more importantly, can you merge master into it and resolve the conflicts? master
has now docusaurus 3, which I suppose doesn't really affect these changes, but I'd like to take a final look with that branch merged 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks so good, I want to cry!
I left for @TucksonDev and you to resolve the trailing slash issue.
We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please sign the linked documents below to get yourself added. https://na3.docusign.net/Member/PowerFormSigning.aspx?PowerFormId=b15c81cc-b5ea-42a6-9107-3992526f2898&env=na3&acct=6e152afc-6284-44af-a4c1-d8ef291db402&v=2 |
"permanent": false | ||
}, | ||
{ | ||
"source": "/for-devs/third-party-docs/:slug*", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"source": "/for-devs/third-party-docs/:slug*", | |
"source": "/for-devs/third-party-docs/:slug*/?", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the modification you required, @TucksonDev?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TucksonDev, picking this up, I added the modification you requested (hopefully, I got it right!).
We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please sign the linked documents below to get yourself added. https://na3.docusign.net/Member/PowerFormSigning.aspx?PowerFormId=b15c81cc-b5ea-42a6-9107-3992526f2898&env=na3&acct=6e152afc-6284-44af-a4c1-d8ef291db402&v=2 |
Note that some file relocations in this PR do not include the addition of a number prefix - intent is to address those types of non-blocking todos in a separate PR.
TODOs before merging:
yarn update:all