Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tip to fix nitro compilation warnings on MacOS #1581

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

gligneul
Copy link
Contributor

No description provided.

Copy link

vercel bot commented Aug 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
arbitrum-docs ✅ Ready (Inspect) Visit Preview Aug 21, 2024 1:46pm

Copy link
Member

@eljobe eljobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with this change. But, I also wonder if we could detect the OS and just set these environment variables in the Makefile instead of having each developer remember it themselves?

@gligneul gligneul merged commit 0b4faf5 into master Aug 21, 2024
2 checks passed
@gligneul gligneul deleted the gligneul/build-nitro-warnings branch August 21, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants