Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create github action workflow with prettier check and reactivate broken links check on build #434

Merged
merged 14 commits into from
Aug 4, 2023
Merged

Create github action workflow with prettier check and reactivate broken links check on build #434

merged 14 commits into from
Aug 4, 2023

Conversation

TucksonDev
Copy link
Contributor

@TucksonDev TucksonDev commented Aug 2, 2023 •
edited
Loading

This PR does the following:

  • Reformat files that were not currently formatted
  • Add a github action for checking that files are formatted
  • Reactivate broken links detection on both dev and prod builds: up to now, docusaurus would warn on dev and would ignore on prod. It now throws on both

By merging this PR, two changes will apply for next contributions:

  1. We will have to run yarn format before updating the PR, otherwise the github check will fail
  2. We will have to verify that there are no broken links by running yarn build or yarn start, otherwise the Vercel deployment will fail

@cla-bot cla-bot bot added the s label Aug 2, 2023
@vercel
Copy link

vercel bot commented Aug 2, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nitro-docs ✅ Ready (Inspect) Visit Preview Aug 2, 2023 4:18pm

@TucksonDev TucksonDev changed the title Create github action workflow with prettier check Create github action workflow with prettier check and reactivate broken links check on build Aug 2, 2023
symbolpunk
symbolpunk approved these changes Aug 4, 2023
View reviewed changes
Copy link
Contributor

@symbolpunk symbolpunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@TucksonDev TucksonDev merged commit d37b045 into master Aug 4, 2023
4 checks passed
@TucksonDev TucksonDev deleted the add-github-workflow-for-prettier branch August 4, 2023 14:53
This was referenced Aug 4, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@symbolpunk symbolpunk symbolpunk approved these changes

@mahsamoosavi mahsamoosavi Awaiting requested review from mahsamoosavi

Assignees
No one assigned
Labels
s
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TucksonDev @symbolpunk