Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(quickstart-hardhat): update deploy.js code to work with latest ve… #662

Merged
merged 2 commits into from
Oct 11, 2023

Conversation

snmkl
Copy link
Contributor

@snmkl snmkl commented Oct 11, 2023

…rsion of hardhat

The previous code with latest hardhat update doesn't work anymore, this produces the same output compiles correctly.

before:

% yarn hardhat run scripts/deploy.js --network localhost
yarn run v1.22.19
$ /Documents/GitHub/arbitrum-test/node_modules/.bin/hardhat run scripts/deploy.js --network localhost
TypeError: vendingMachine.deployed is not a function
    at main (/Documents/GitHub/arbitrum-test/scripts/deploy.js:6:24)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
error Command failed with exit code 1.

after:

% yarn hardhat run scripts/deploy.js --network localhost
yarn run v1.22.19
$ /Documents/GitHub/arbitrum-test/node_modules/.bin/hardhat run scripts/deploy.js --network localhost
Cupcake vending machine deployed to <address>
✨  Done in 1.51s.

@cla-bot cla-bot bot added the s label Oct 11, 2023
@vercel
Copy link

vercel bot commented Oct 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nitro-docs ✅ Ready (Inspect) Visit Preview Oct 11, 2023 9:55pm

Copy link
Contributor

@symbolpunk symbolpunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this fix!

@symbolpunk symbolpunk merged commit fc66282 into OffchainLabs:master Oct 11, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants