-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add v1 ArbOwnerPublic setters #149
base: main
Are you sure you want to change the base?
Conversation
3cdefd5
to
8c5caaa
Compare
import { validateChildChainPublicClient } from '../types/validateChildChainPublicClient'; | ||
|
||
export type AddChainOwnerParameters = Prettify< | ||
WithUpgradeExecutor< |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...withUpgradeExecutor({ | ||
to: arbOwner.address, | ||
upgradeExecutor, | ||
args: [recipient], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i am wondering if we would like to check the Address
type in this function, or outside? currently it is set up to be done outside of this function
what are your thoughts?
e8786b0
to
4ca765e
Compare
part of FS-529