Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update package.json #265

Merged
merged 2 commits into from
Apr 27, 2023
Merged

chore: update package.json #265

merged 2 commits into from
Apr 27, 2023

Conversation

Jason-Wanxt
Copy link
Contributor

Since we have some new changes to nitro-contract, the current sdk abi has some incompatibility with the latest nitro contract.

@spsjvc spsjvc changed the title Update package.json chore: update package.json Apr 27, 2023
Copy link
Member

@spsjvc spsjvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very big yarn.lock diff for just one bump in dependencies. @Jason-Wanxt can you double-check if this is all good?

@gzeoneth
Copy link
Member

This is a very big yarn.lock diff for just one bump in dependencies. @Jason-Wanxt can you double-check if this is all good?

I think its good there is a new big sol2uml dependency added

@fionnachan
Copy link
Member

@spsjvc I copy-and-pasted main's yarn.lock and ran yarn again with the new package ver and the changes are the same

can you please approve the PR and merge it

@spsjvc spsjvc self-requested a review April 27, 2023 18:49
@spsjvc spsjvc merged commit 4cedb1f into main Apr 27, 2023
@spsjvc spsjvc deleted the update-contracts branch April 27, 2023 18:49
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants