feat: return status in L2ToL1Message.waitUntilReadyToExecute #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yahgwai
approved these changes
Dec 12, 2023
| @@ -349,18 +349,20 @@ export class L2ToL1MessageReaderClassic extends L2ToL1MessageClassic { | |||
| * WARNING: Outbox entries are only created when the corresponding node is confirmed. Which | |||
| * can take 1 week+, so waiting here could be a very long operation. | |||
| * @param retryDelay | |||
| * @returns | |||
| * @returns outbox entry status (either executed or confirmed but not executed) | |||
There was a problem hiding this comment.
"either executed or confirmed but not executed" - should be not pending?
spsjvc
approved these changes
Dec 13, 2023
spsjvc
changed the title
spsjvc
changed the title
L2ToL1Message.waitUntilReadyToExecute
spsjvc
changed the title
L2ToL1Message.waitUntilReadyToExecute
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.