Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

more informative gas estimator error #418

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

more informative gas estimator error #418

wants to merge 4 commits into from
+26 −8

Conversation

godzillaba
Copy link
Contributor

@godzillaba godzillaba commented Mar 1, 2024 •
edited
Loading

changed nitro testnode ref from master to release because it wasn't working

sometimes the error message is pretty unhelpful when doing retryable gas estimation. below is an example of a failure due to insufficient erc20 allowance.

stack trace before:

Error: No retryable data found in error
      at ...
  Caused By: Error: no matching error (argument="sighash", value="0x08c379a0", code=INVALID_ARGUMENT, version=abi/5.7.0)
      at ...

stack trace after:

Error: No retryable data found in error
      at ...
  Caused By: Error: No retryable data found in error: 0x08c379a00000000000000000000000000000000000000000000000000000000000000020000000000000000000000000000000000000000000000000000000000000001d45524332303a20696e73756666696369656e7420616c6c6f77616e6365000000
      at ...

@cla-bot cla-bot bot added the cla-signed label Mar 1, 2024
@vercel Vercel
Copy link

vercel bot commented Mar 1, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
arbitrum-sdk ✅ Ready (Inspect) Visit Preview Mar 1, 2024 5:09pm

@godzillaba godzillaba changed the title Ha/informative gas estimator error more informative gas estimator error Mar 1, 2024
douglance
douglance reviewed Mar 8, 2024
View reviewed changes
Copy link
Contributor

@douglance douglance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was the reversion of changes to L1toL2MessageGasEstimator intentional?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@douglance douglance douglance left review comments

@DZGoldman DZGoldman Awaiting requested review from DZGoldman

@dewanshparashar dewanshparashar Awaiting requested review from dewanshparashar dewanshparashar was automatically assigned from OffchainLabs/full-stack

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@godzillaba @douglance