feat: update depositTo to use standard deposit
#432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
gzeoneth
requested changes
Mar 19, 2024
src/lib/assetBridger/ethBridger.ts
Outdated
| params.retryableGasOverrides | ||
| ) | ||
|
|
||
| const tx = await inbox.connect(params.l1Signer).unsafeCreateRetryableTicket( |
There was a problem hiding this comment.
why are we using unsafeCreateRetryableTicket here? can be dangerous
There was a problem hiding this comment.
changed to createRetryableTicket
gzeoneth
requested changes
Mar 19, 2024
src/lib/assetBridger/ethBridger.ts
Outdated
| '0x', // data, | ||
| { | ||
| from: signerAddress.value, | ||
| value: amount, |
There was a problem hiding this comment.
actually this should be
Suggested change
| value: amount, | |
| value: gasEstimation.deposit, |
…bitrum-sdk into depositTo-refactor
…o depositTo-refactor
spsjvc
reviewed
Apr 30, 2024
tests/integration/eth.test.ts
Outdated
| destWallet.address | ||
| ) | ||
| expect( | ||
| testWalletL2EthBalance.lt(ethToDeposit), |
tests/integration/eth.test.ts
Outdated
| @@ -211,6 +216,60 @@ describe('Ether', async () => { | |||
| ) | |||
| }) | |||
|
|
|||
| it('deposit ether to a specific L2 address and check balance before auto-redeem', async () => { | |||
There was a problem hiding this comment.
Suggested change
| it('deposit ether to a specific L2 address and check balance before auto-redeem', async () => { | |
| it('deposit ether to a specific L2 address with manual redeem', async () => { |
tests/integration/eth.test.ts
Outdated
| const rec = await res.wait() | ||
| const l1ToL2Messages = await rec.getL1ToL2Messages(l2Signer.provider!) | ||
| expect(l1ToL2Messages.length).to.eq(1, 'failed to find 1 l1 to l2 message') | ||
| let l1ToL2Message = l1ToL2Messages[0] |
There was a problem hiding this comment.
Suggested change
| let l1ToL2Message = l1ToL2Messages[0] | |
| const l1ToL2MessageReader = l1ToL2Messages[0] |
tests/integration/eth.test.ts
Outdated
Comment on lines
260
to
265
| l1ToL2Message = l1Receipt.getL1ToL2Messages(l2Signer)[0] | ||
|
|
||
| if (l1ToL2Message instanceof L1ToL2MessageWriter) { | ||
| const res = await l1ToL2Message.redeem() | ||
| await res.wait() | ||
| } |
There was a problem hiding this comment.
Suggested change
| l1ToL2Message = l1Receipt.getL1ToL2Messages(l2Signer)[0] | |
| if (l1ToL2Message instanceof L1ToL2MessageWriter) { | |
| const res = await l1ToL2Message.redeem() | |
| await res.wait() | |
| } | |
| const l1ToL2MessageWriter = l1Receipt.getL1ToL2Messages(l2Signer)[0] | |
| await (await l1ToL2MessageWriter.redeem()).wait() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes FS-368