fix: adjust blockTime inside InboxTools.findFirstBlockBelow in v3
#475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
brtkx
changed the title
blockTime inside InboxTools.findFirstBlockBelow in v3
gzeoneth
reviewed
Jun 7, 2024
src/lib/inbox/inbox.ts
Outdated
| this.l1Provider as JsonRpcProvider | ||
| ) | ||
| const currentArbBlock = await arbProvider.getBlock( | ||
| await arbProvider.getBlockNumber() |
There was a problem hiding this comment.
I think we can use "latest" instead of making 2 calls?
src/lib/inbox/inbox.ts
Outdated
| @@ -183,7 +234,8 @@ export class InboxTools { | |||
| await multicall.multiCall(multicallInput, true) | |||
|
|
|||
| const firstEligibleBlockNumber = | |||
| currentBlockNumber.toNumber() - maxTimeVariation.delayBlocks.toNumber() | |||
| (currentL1BlockNumber ?? currentBlockNumber.toNumber()) - | |||
There was a problem hiding this comment.
use isParentChainArbitrum ? instead of currentL1BlockNumber ??, doesn't matter too much tho
src/lib/inbox/inbox.ts
Outdated
| @@ -90,6 +95,38 @@ export class InboxTools { | |||
| blockNumber: number, | |||
| blockTimestamp: number | |||
| ): Promise<Block> { | |||
| const isParentChainArbitrum = await isArbitrumChain(this.l1Provider) | |||
|
|
|||
| const nodeInterface = NodeInterface__factory.connect( | |||
There was a problem hiding this comment.
can be defined within the next if
There was a problem hiding this comment.
const diffBlocks = Math.max(Math.ceil(diff / this.l1Network.blockTime), 10)
I think we need to hardcode the blocktime here because we want to real "L1" block time here but l1Network.blockTime for a L3 chain can be the L2 block time?
spsjvc
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.