feat: check if token is registered on gateways #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…Labs/arbitrum-sdk into isCustomGatewayRegistered
…o isCustomGatewayRegistered
spsjvc
reviewed
Jun 13, 2024
src/lib/assetBridger/erc20Bridger.ts
Outdated
| l2Provider | ||
| ).calculateL2TokenAddress(erc20L1Address) | ||
|
|
||
| return tokenL2AddressFromL1GatewayRouter === l2AddressFromL2Gateway |
There was a problem hiding this comment.
we should lowercase both just in case
src/lib/assetBridger/erc20Bridger.ts
Outdated
Comment on lines
845
to
852
| /** | ||
| * Checks if custom gateway has been registered | ||
| * @param erc20L1Address | ||
| * @param l1Provider | ||
| * @param l2Provider | ||
| * @returns | ||
| */ | ||
| public async isCustomGatewayRegistered({ |
There was a problem hiding this comment.
Suggested change
| /** | |
| * Checks if custom gateway has been registered | |
| * @param erc20L1Address | |
| * @param l1Provider | |
| * @param l2Provider | |
| * @returns | |
| */ | |
| public async isCustomGatewayRegistered({ | |
| /** | |
| * Checks if the token has been properly registered on both gateways. Mostly useful for tokens that use a custom gateway. | |
| * | |
| * @param erc20L1Address | |
| * @param l1Provider | |
| * @param l2Provider | |
| * @returns | |
| */ | |
| public async isRegistered({ |
brtkx
changed the title
isCustomGatewayRegistered function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.