-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: check if token is registered on gateways #481
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…Labs/arbitrum-sdk into isCustomGatewayRegistered
…o isCustomGatewayRegistered
src/lib/assetBridger/erc20Bridger.ts
Outdated
l2Provider | ||
).calculateL2TokenAddress(erc20L1Address) | ||
|
||
return tokenL2AddressFromL1GatewayRouter === l2AddressFromL2Gateway |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should lowercase both just in case
src/lib/assetBridger/erc20Bridger.ts
Outdated
/** | ||
* Checks if custom gateway has been registered | ||
* @param erc20L1Address | ||
* @param l1Provider | ||
* @param l2Provider | ||
* @returns | ||
*/ | ||
public async isCustomGatewayRegistered({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/** | |
* Checks if custom gateway has been registered | |
* @param erc20L1Address | |
* @param l1Provider | |
* @param l2Provider | |
* @returns | |
*/ | |
public async isCustomGatewayRegistered({ | |
/** | |
* Checks if the token has been properly registered on both gateways. Mostly useful for tokens that use a custom gateway. | |
* | |
* @param erc20L1Address | |
* @param l1Provider | |
* @param l2Provider | |
* @returns | |
*/ | |
public async isRegistered({ |
isCustomGatewayRegistered
functionThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.