feat: move token state into query params #1770
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…e into token-query-params
brtkx
changed the title
|
|
||
| // We want to be sure this fetch is completed by the time we open the USDC modals | ||
| useCCTPIsBlocked() | ||
|
|
||
| const [tokenBridgeParams, setTokenBridgeParams] = | ||
| useState<TokenBridgeParams | null>(null) | ||
|
|
||
| useEffect(() => { |
There was a problem hiding this comment.
This caused a lot of rerenders because useSelectedToken uses tokenBridge data under the hood. This block of code is not needed anyway because we set token to null when networks change
| @@ -558,43 +553,9 @@ export function TokenSearch({ | |||
| } | |||
|
|
|||
| try { | |||
| // Native USDC on L2 won't have a corresponding L1 address | |||
There was a problem hiding this comment.
Moved this logic to useSelectedToken.
useSelectedToken now only requires erc20ParentAddress and all the computation whether it's USDC or not is handled there.
| @@ -210,7 +218,7 @@ export function TransferPanel() { | |||
| ) | |||
|
|
|||
| function closeWithResetTokenImportDialog() { | |||
| setTokenQueryParam(undefined) | |||
| setTokenQueryParam(null) | |||
There was a problem hiding this comment.
It's nicer to have null instead of undefined so that data is consistent with selectedToken
| @@ -225,6 +233,36 @@ export function TransferPanel() { | |||
| connectionState | |||
| }) | |||
|
|
|||
| const isTokenAlreadyImported = useMemo(() => { | |||
There was a problem hiding this comment.
Checks if token is already imported before we show the token import dialog. This way when we refresh the page we won't show the dialog all the time.
| import { CommonAddress } from '../../../util/CommonAddressUtils' | ||
| import { isNetwork } from '../../../util/networks' | ||
|
|
||
| const commonUSDC = { |
There was a problem hiding this comment.
Moved to useSelectedToken as the logic is handled there
…e into token-query-params
| parentChain.id, | ||
| childChain.id, | ||
| tokenFromSearchParams, | ||
| Object.keys(tokensFromLists), |
| decimals: 6, | ||
| listIds: new Set() | ||
| }) | ||
| if (isTokenNativeUSDC(_token.address)) { |
There was a problem hiding this comment.
double check if we still need this
…e into token-query-params
…-token-bridge into token-query-params
…e into token-query-params
…e into token-query-params
|
|
||
| const isTestnetMode = isNetwork(networks.sourceChain.id).isTestnet | ||
|
|
||
| const toggleTestnetMode = useCallback(() => { | ||
| setNetworks({ | ||
| sourceChainId: isTestnetMode ? ChainId.Ethereum : ChainId.Sepolia | ||
| }) | ||
| }, [isTestnetMode, setNetworks]) | ||
| setSelectedToken(null) |
There was a problem hiding this comment.
Can we have a global listener for network change, so if network is changed in a different place, we don't forget to reset the selected token?
closes FS-675