chore: rename teleporter helpers #1823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dewanshparashar
changed the title
douglance
previously approved these changes
Aug 5, 2024
brtkx
reviewed
Aug 5, 2024
| @@ -250,7 +249,7 @@ export const TransactionsTableDetailsSteps = ({ | |||
| /> | |||
|
|
|||
| {/* Pending transfer showing the remaining time */} | |||
| {!isTeleport(tx) && ( | |||
| {!isTeleporterTransaction(tx) && ( | |||
There was a problem hiding this comment.
Suggested change
| {!isTeleporterTransaction(tx) && ( | |
| {!isTeleportTx && ( |
| @@ -272,7 +271,7 @@ export const TransactionsTableDetailsSteps = ({ | |||
| /> | |||
| )} | |||
|
|
|||
| {isTeleport(tx) && isTeleporterTransaction(tx) && ( | |||
| {isTeleporterTransaction(tx) && ( | |||
There was a problem hiding this comment.
Suggested change
| {isTeleporterTransaction(tx) && ( | |
| {isTeleportTx && ( |
| isDeposit, | ||
| isNativeCurrencyTransfer, | ||
| isSupported, | ||
| isValidTeleportChainPair |
There was a problem hiding this comment.
maybe this should stay as isTeleport, because it refers to the transfer type not chain pairs in here I think?
dewanshparashar
changed the title
brtkx
previously approved these changes
Aug 6, 2024
…e into feat-rename-teleport-utils
brtkx
approved these changes
Sep 3, 2024
douglance
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a confusion between utility methods
isTeleportvsisTeleporterTransaction.isTeleportis a boolean which denotes if the source and destination id's provided to it correspond to teleporter config - it's much more simpler to use in terms of function input - but doesn't help with typescript. - Renamed it toisValidTeleportChainPairisTeleportTxwas the util method that is being used to assert a transaction (merged tx, tx or any other transaction type we have) is a teleporter transaction - using it wherever we are asserting type of teleport tx.FS-725