test: Add CCTP E2E tests to CI #1843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| cy.confirmSpending(USDCAmountToSend.toString()) | ||
|
|
||
| /** | ||
| * Currently synpress cy.confirmMetamaskTransaction doesn't work on Sepolia |
There was a problem hiding this comment.
Is there no way to fix this currently? We are also skipping 1 test coz of it which isn't ideal.
fionnachan
reviewed
Sep 3, 2024
.github/workflows/build-test.yml
Outdated
Comment on lines
158
to
165
| e2e_content=$(cat packages/arb-token-bridge-ui/tests/e2e/specfiles.json | jq --compact-output .) | ||
| cctp_content=$(cat packages/arb-token-bridge-ui/tests/e2e/cctp.json | jq --compact-output .) | ||
|
|
||
| e2e_with_orbit=$(echo "$e2e_content" | jq '[.[] | {type: "regular", name: .name, file: .file, recordVideo: .recordVideo, orbitTest: "0"}, {type: "regular", name: .name, file: .file, recordVideo: .recordVideo, orbitTest: "1"}]' | jq . --compact-output) | ||
| cctp_formatted=$(echo "$cctp_content" | jq '[.[] | {type: "cctp", name: .name, file: .file, recordVideo: .recordVideo, orbitTest: null}]' | jq . --compact-output) | ||
|
|
||
| combined_content=$(echo "$e2e_with_orbit $cctp_formatted" | jq -s 'add' --compact-output) | ||
| echo "e2eFiles=$combined_content" >> $GITHUB_OUTPUT |
There was a problem hiding this comment.
this is way too chunky to read now
can you clean this up please?
we can also handle this in a separate file rather than inlining the processing script
.github/workflows/build-test.yml
Outdated
| test-e2e: | ||
| name: "Test E2E${{ matrix.orbit-test == '1' && ' with L3' || '' }} - ${{ matrix.tests.name }}" | ||
| name: "Test ${{ matrix.test.type == 'cctp' && 'E2E CCTP' || 'E2E' }}${{ matrix.test.type == 'regular' && matrix.test.orbitTest == '1' && ' with L3' || '' }} - ${{ matrix.test.name }}" |
There was a problem hiding this comment.
Suggested change
| name: "Test ${{ matrix.test.type == 'cctp' && 'E2E CCTP' || 'E2E' }}${{ matrix.test.type == 'regular' && matrix.test.orbitTest == '1' && ' with L3' || '' }} - ${{ matrix.test.name }}" | |
| name: "Test E2E ${{ matrix.test.type == 'cctp' && 'CCTP' || matrix.test.orbitTest == '1' && 'with L3' }} - ${{ matrix.test.name }}" |
does this work?
.github/workflows/build-test.yml
Outdated
|
|
||
| - name: Run e2e tests via cypress-io/github-action | ||
| uses: cypress-io/github-action@8d3918616d8ac34caa2b49afc8b408b6a872a6f5 # pin@v6.7.1 | ||
| with: | ||
| start: yarn start | ||
| command: ${{ matrix.orbit-test == '1' && 'yarn test:e2e:orbit --browser chromium' || 'yarn test:e2e --browser chromium' }} | ||
| command: ${{ matrix.test.type == 'cctp' && 'yarn test:e2e:cctp --browser chromium' || (matrix.test.orbitTest == '1' && 'yarn test:e2e:orbit --browser chromium' || 'yarn test:e2e --browser chromium') }} |
There was a problem hiding this comment.
Suggested change
| command: ${{ matrix.test.type == 'cctp' && 'yarn test:e2e:cctp --browser chromium' || (matrix.test.orbitTest == '1' && 'yarn test:e2e:orbit --browser chromium' || 'yarn test:e2e --browser chromium') }} | |
| command: "yarn test:e2e${{ matrix.test.type == 'cctp' && ':cctp' || matrix.test.orbitTest == '1' && ':orbit' }} --browser chromium" |
does this work?
Comment on lines
+62
to
+69
| const SEPOLIA_INFURA_RPC_URL = `https://sepolia.infura.io/v3/${INFURA_KEY}` | ||
| const sepoliaRpcUrl = | ||
| process.env.NEXT_PUBLIC_SEPOLIA_RPC_URL ?? SEPOLIA_INFURA_RPC_URL | ||
| const arbSepoliaRpcUrl = 'https://sepolia-rollup.arbitrum.io/rpc' | ||
|
|
||
| const sepoliaProvider = new StaticJsonRpcProvider(sepoliaRpcUrl) | ||
| const arbSepoliaProvider = new StaticJsonRpcProvider(arbSepoliaRpcUrl) | ||
|
|
fionnachan
reviewed
Sep 3, 2024
| }) | ||
| }) | ||
|
|
||
| console.log(JSON.stringify(tests)) |
dewanshparashar
approved these changes
Sep 4, 2024
fionnachan
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes fs-729
Summary
Steps to test