feat: transaction history for batch transfers #1851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e into batch-erc20-eth-1
…token-bridge into batch-erc20-eth-2
…token-bridge into batch-erc20-eth-4
…e into batch-erc20-eth-2
…token-bridge into batch-erc20-eth-3
…token-bridge into batch-erc20-eth-4
…e into batch-erc20-eth-6
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
fionnachan
previously approved these changes
Aug 21, 2024
spsjvc
reviewed
Aug 21, 2024
| }: { | ||
| l1ToL2Msg: ParentToChildMessageReader | ||
| }) => { | ||
| const childReceipt = await l1ToL2Msg.getAutoRedeemAttempt() |
There was a problem hiding this comment.
not sure if this will work if the retryable was manually redeemed
…token-bridge into batch-erc20-eth-6
…token-bridge into batch-erc20-eth-6
spsjvc
reviewed
Aug 22, 2024
| // we deduct gas cost from max submission fee, which leaves us with amount2 (extra ETH sent with ERC-20) | ||
| if (depositStatus === 'success') { | ||
| // if success, we use the actual gas cost | ||
| const gasCost = await getRetryableFeeOnChildChain({ |
There was a problem hiding this comment.
OnChildChain is redundant
Suggested change
| const gasCost = await getRetryableFeeOnChildChain({ | |
| const retryableFee = await getRetryableFee({ |
Comment on lines
195
to
209
| const excessGas = maxSubmissionFeeNumber - estimatedGasNumber | ||
|
|
||
| // based on averages and min/max values from previous hundreds of txs | ||
| if (excessGas < 0.001) { | ||
| return false | ||
| } | ||
|
|
||
| const estimatedGasUsedPercentage = | ||
| (estimatedGasNumber / maxSubmissionFeeNumber) * 100 | ||
|
|
||
| if (estimatedGasUsedPercentage > 10) { | ||
| return false | ||
| } | ||
|
|
||
| return true |
There was a problem hiding this comment.
condense this so it's quicker to get what's going on
Suggested change
| const excessGas = maxSubmissionFeeNumber - estimatedGasNumber | |
| // based on averages and min/max values from previous hundreds of txs | |
| if (excessGas < 0.001) { | |
| return false | |
| } | |
| const estimatedGasUsedPercentage = | |
| (estimatedGasNumber / maxSubmissionFeeNumber) * 100 | |
| if (estimatedGasUsedPercentage > 10) { | |
| return false | |
| } | |
| return true | |
| const excessGasFee = maxSubmissionFeeNumber - estimatedGasNumber | |
| const percentageGasUsed = (estimatedGasNumber / maxSubmissionFeeNumber) * 100 | |
| // heuristic for determining if it's a batch transfer (based on maxSubmissionFee) | |
| return excessGas >= 0.001 && percentageGasUsed < 10 |
spsjvc
approved these changes
Aug 22, 2024
fionnachan
approved these changes
Aug 22, 2024
dewanshparashar
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-6 from https://www.notion.so/arbitrum/Batched-ERC20-ETH-transfers-0df3704c9aef464cb443c0b97d852465
Enable the feature with query param
experiments=batchThings to note:
retryable.maxSubmissionCostbefore transfer, users may receive a bit more ETH thanamount2(amount2+ unused refunded gas). Transaction history may show more ETH than it was actually sent. We show a disclaimer for this.amount2in local storage. If not found in local storage, we fallback to fetching this on chain. Edit: even then it's not accurate and the final gas cost will make it a little bit different. We show the tooltip (on amount2 hover in transaction history) explaining that amount2 is just an estimate. This tooltip is shown at all times, even for the final result (for less complexity, I don't think it matters much).