feat: input toggle for batched transfers #1852
Conversation
…e into batch-erc20-eth-1
…token-bridge into batch-erc20-eth-2
…token-bridge into batch-erc20-eth-4
…e into batch-erc20-eth-2
…token-bridge into batch-erc20-eth-3
…token-bridge into batch-erc20-eth-4
…e into batch-erc20-eth-6
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| You are able to move ETH in the same transaction, but you are | ||
| not required to do so. This is the minimum ETH amount you will | ||
| get, but you may get a bit more dependent on the gas usage. |
There was a problem hiding this comment.
| You are able to move ETH in the same transaction, but you are | |
| not required to do so. This is the minimum ETH amount you will | |
| get, but you may get a bit more dependent on the gas usage. | |
| You can transfer ETH in the same transaction if you wish to. This is the approximate amount you will receive. The final amount depends on actual gas usage. It usually varies by 0.00x ETH. |
we should give an approx of 0.00x ETH so that users know what to expect
i am not entirely sure if it is the minimum or can be less than the amount user inputs
feel free to adjust the text accordingly
There was a problem hiding this comment.
+1 - The content here should be approved by the product team.
There was a problem hiding this comment.
I'm not sure about specifying the approximate amount, it's pretty much the amount you write in the amount2 input
| @@ -163,6 +183,9 @@ export function TransferPanelMainInput(props: TransferPanelMainInputProps) { | |||
| )} | |||
| > | |||
| <TransferPanelInputField {...rest} /> | |||
| {typeof inputCollapseOnClick !== 'undefined' && ( | |||
| <CollapseInputButton onClick={inputCollapseOnClick} /> | |||
There was a problem hiding this comment.
I am not sure if we should have the Close button within the input field beside max button. I think it should be outside of the input, shrinking the field a by a little bit - we must consult design team to finalize this.
| You are able to move ETH in the same transaction, but you are | ||
| not required to do so. This is the minimum ETH amount you will | ||
| get, but you may get a bit more dependent on the gas usage. |
There was a problem hiding this comment.
+1 - The content here should be approved by the product team.
…e into batch-erc20-eth-7
…token-bridge into batch-erc20-eth-7
PR-7 from https://www.notion.so/arbitrum/Batched-ERC20-ETH-transfers-0df3704c9aef464cb443c0b97d852465
Enable the feature with query param
experiments=batch