chore: rename deposits/helpers.ts to parent/child
#1855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
fionnachan
reviewed
Aug 21, 2024
There was a problem hiding this comment.
i am lost now, i actually don't know if child chain means L2 or L3 (the final destination) here after reading the names
can you figure out and make them clear?
There was a problem hiding this comment.
They work for both L1>L2 and L2>L3. parent/child is appropriate here.
Co-authored-by: Fionna Chan <13184582+fionnachan@users.noreply.github.com>
fionnachan
previously approved these changes
Aug 22, 2024
packages/arb-token-bridge-ui/src/hooks/useTransactionHistory.ts
Outdated
Show resolved
Hide resolved
dewanshparashar
approved these changes
Aug 26, 2024
dewanshparashar
approved these changes
Aug 26, 2024
fionnachan
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Steps to test