Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about upgrading solc version #209

Closed
sveitser opened this issue Jul 10, 2024 · 1 comment
Closed

Question about upgrading solc version #209

sveitser opened this issue Jul 10, 2024 · 1 comment

Comments

@sveitser
Copy link

We have some small additions in our fork https://github.com/EspressoSystems/nitro-contracts for the integration with the Espresso sequencer. We are now running into an issue where RollupUserLogic.sol exceeds the 24 kB size limit by a tiny bit (even if we set the optimizer runs to 1).

This problem goes away if we use a newer solc, for example 0.8.26.

I saw that in d86ee9d a previous update to solc was reverted. So we're wondering if there any concerns with using more recent versions of solc.

cc @gvladika @ImJeremyHe

@gzeoneth
Copy link
Member

Out of an abundance of caution, we avoid bumping solc version unless necessary. That said, there are no known issue at this moment that bumping solc may causes.

We are aware of the tight contract size of RollupUserLogic and in fact v2.1.0 might have pushed it to the limit. Hopefully this will go away when we ship v3 (BOLD) which have a much smaller RollupUserLogic size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants