-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: bold #193
Open
gzeoneth
wants to merge
70
commits into
develop
Choose a base branch
from
bold-merge
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: bold #193
+21,258
−8,260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Lee Bousfield <ljbousfield@gmail.com> Co-authored-by: Chris Buckland <cpbuckland88@gmail.com> Co-authored-by: shotaro <shawtarohgn@gmail.com> Co-authored-by: Henry <11198460+godzillaba@users.noreply.github.com>
This reverts commit 8269b1a.
Co-authored-by: Chris Buckland <cpbuckland88@gmail.com> Co-authored-by: Henry <11198460+godzillaba@users.noreply.github.com>
fix conflicts for bold merge
gzeoneth
commented
Aug 8, 2024
* feat: also migrate anyTrustFastConfirmer if existed * fix: use IRollupAdmin * fix: IRollupAdmin.setAnyTrustFastConfirmer * docs: comment on try anyTrustFastConfirmer * fix: remove anyTrustFastConfirmer in upgrade settings * fix: remove anyTrustFastConfirmer in Settings struct * test: disable fast confirmer check * test: empty anyTrustFastConfirmer
* configs * note * note * feat: safer hoursToBlocks util * delay buffer * chore: update configs * fix: circular import * chore: param update * chore: remove debug * fix: restore validators * fix: typo * fix: remove unused error * chore: fix slither * comment --------- Co-authored-by: gzeon <im@gzeon.dev> Co-authored-by: gzeon <hng@offchainlabs.com>
* chore: forge fmt * chore: remove prettier in solhint * chore: turn off var-name-mixedcase * fix: state-visibility * chore: ignore avoid-low-level-calls * chore: solhint ignore * chore: prettierignore update * chore: update yarn format script * chore: yarn format * ci: enable format and lint * chore: foundry default format config * chore: remove sol config in prettier * chore: set line_length back to 100 * chore: multiline_func_header params_first * chore: update slither db * ci: enable lint * chore: yarn format * chore: update slither db * fix: format * fix: format foundryup
* fix: orbit ts * fix: format
* fix: lint issues * fix: slither db
* Merkle tree lib comment updates * Comment updates * Updated comments on the merkle tree accumulator lib * Added comments to the merkle tree lib verify prefix proof * Formatting * format: yarn format * fix: typo * chore: fix slither --------- Co-authored-by: gzeon <hng@offchainlabs.com> Co-authored-by: gzeon <im@gzeon.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
merging OffchainLabs/bold@6b42a38f /contracts into
nitro-contracts
contracts should be identical to the https://github.com/OffchainLabs/bold except some mocks, precompiles interface, and some renamed variables in BOLDUpgradeAction
e2e test is currently disabled due to lack of nitro support
resolves BLK-176