Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bold #193

Open
wants to merge 70 commits into
base: develop
Choose a base branch
from
Open

feat: bold #193

wants to merge 70 commits into from

Conversation

gzeoneth
Copy link
Member

@gzeoneth gzeoneth commented Jun 18, 2024

merging OffchainLabs/bold@6b42a38f /contracts into nitro-contracts

contracts should be identical to the https://github.com/OffchainLabs/bold except some mocks, precompiles interface, and some renamed variables in BOLDUpgradeAction

$ diff -qr ./src ../bold/contracts/src
Only in ./src: chain
Only in ./src/mocks: Benchmarks.sol
Only in ./src/mocks: MultiCallTest.sol
Only in ./src/mocks: PendingBlkTimeAndNrAdvanceCheck.sol
Only in ./src/mocks: Program.sol
Only in ./src/mocks: SdkStorage.sol
Only in ./src/mocks: SimpleCacheManager.sol
Files ./src/precompiles/ArbWasmCache.sol and ../bold/contracts/src/precompiles/ArbWasmCache.sol differ
Files ./src/rollup/BOLDUpgradeAction.sol and ../bold/contracts/src/rollup/BOLDUpgradeAction.sol differ

e2e test is currently disabled due to lack of nitro support

resolves BLK-176

Co-authored-by: Lee Bousfield <ljbousfield@gmail.com>
Co-authored-by: Chris Buckland <cpbuckland88@gmail.com>
Co-authored-by: shotaro <shawtarohgn@gmail.com>
Co-authored-by: Henry <11198460+godzillaba@users.noreply.github.com>
@cla-bot cla-bot bot added the s label Jun 18, 2024
src/rollup/RollupCore.sol Fixed Show fixed Hide fixed
src/rollup/RollupCore.sol Fixed Show fixed Hide fixed
src/rollup/RollupCore.sol Fixed Show fixed Hide fixed
src/rollup/RollupCore.sol Fixed Show fixed Hide fixed
src/rollup/RollupCore.sol Fixed Show fixed Hide fixed
src/challengeV2/EdgeChallengeManager.sol Fixed Show fixed Hide fixed
src/rollup/BOLDUpgradeAction.sol Fixed Show fixed Hide fixed
src/challengeV2/EdgeChallengeManager.sol Fixed Show fixed Hide fixed
@gzeoneth gzeoneth marked this pull request as draft July 9, 2024 08:13
@gzeoneth gzeoneth marked this pull request as ready for review July 18, 2024 05:28
gzeoneth and others added 9 commits August 15, 2024 18:26
* feat: also migrate anyTrustFastConfirmer if existed

* fix: use IRollupAdmin

* fix: IRollupAdmin.setAnyTrustFastConfirmer

* docs: comment on try anyTrustFastConfirmer

* fix: remove anyTrustFastConfirmer in upgrade settings

* fix: remove anyTrustFastConfirmer in Settings struct

* test: disable fast confirmer check

* test: empty anyTrustFastConfirmer
* configs

* note

* note

* feat: safer hoursToBlocks util

* delay buffer

* chore: update configs

* fix: circular import

* chore: param update

* chore: remove debug

* fix: restore validators

* fix: typo

* fix: remove unused error

* chore: fix slither

* comment

---------

Co-authored-by: gzeon <im@gzeon.dev>
Co-authored-by: gzeon <hng@offchainlabs.com>
* chore: forge fmt

* chore: remove prettier in solhint

* chore: turn off var-name-mixedcase

* fix: state-visibility

* chore: ignore avoid-low-level-calls

* chore: solhint ignore

* chore: prettierignore update

* chore: update yarn format script

* chore: yarn format

* ci: enable format and lint

* chore: foundry default format config

* chore: remove sol config in prettier

* chore: set line_length back to 100

* chore: multiline_func_header params_first

* chore: update slither db

* ci: enable lint

* chore: yarn format

* chore: update slither db

* fix: format

* fix: format foundryup
* fix: orbit ts

* fix: format
gzeoneth and others added 4 commits September 3, 2024 23:37
* fix: lint issues

* fix: slither db
* Merkle tree lib comment updates

* Comment updates

* Updated comments on the merkle tree accumulator lib

* Added comments to the merkle tree lib verify prefix proof

* Formatting

* format: yarn format

* fix: typo

* chore: fix slither

---------

Co-authored-by: gzeon <hng@offchainlabs.com>
Co-authored-by: gzeon <im@gzeon.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants