Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bridge: add pausable outbox execution, inbox updating, and delayed msg enqueueing #107

Draft
wants to merge 2 commits into
base: bridge-access-control
Choose a base branch
from

Conversation

DZGoldman
Copy link
Contributor

the pause delayed msg enqueuing role supplants the pausable inbox if we want to remove that

@cla-bot cla-bot bot added the s label Jan 10, 2024
@DZGoldman DZGoldman mentioned this pull request Jan 10, 2024
@DZGoldman
Copy link
Contributor Author

hm, so currently "inbox updating" = both batch posting and force-including; maybe we'd want to make those separately pausable?

@DZGoldman
Copy link
Contributor Author

^ maybe we remove PausableUpgradable from the inbox inheritance and add an empty storage slot for _paused?

function _grantAllPauseRolesTo(address owner) internal {
_grantRole(DEFAULT_ADMIN_ROLE, owner);
_grantRole(PAUSE_OUTBOX_EXECUTION_ROLE, owner);
_grantRole(UNPAUSE_OUTBOX_EXECUTION_ROLE, owner);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thinking maybe the separate pause/unpause roles aren't necessary (and if we wanted to split up pause/unpause affordances we could do so via smart contract wallet)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant