-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimisations in the sequencer inbox #68
Conversation
…tro-contracts into seq-inbox-bridge
Move event and delayed inbox messages read to the bridge
delayBlocks = maxTimeVariation_.delayBlocks; | ||
futureBlocks = maxTimeVariation_.futureBlocks; | ||
delaySeconds = maxTimeVariation_.delaySeconds; | ||
futureSeconds = maxTimeVariation_.futureSeconds; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
worth noting the uint64 cast below is not safe, this is an existing issue and will only be a problem with misconfiguration; tho we might also consider to have some sanity check here to make sure each value is within some bound
or we can just perform some check there, we already check for underflow but not overflow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's fine to have maxtimevariation as uint64s right? I've updated to that now
59b6dcf
to
31fd3c6
Compare
The I would either make the I presume a refactor of the gasRefunder is planned given the eip 4844 support #96 , just highlighting the need. |
ICommon.BatchDataLocation dataLocation | ||
); | ||
|
||
function postUpgradeInit() external onlyDelegated onlyProxyOwner { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we include setSequencerInbox in here too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeh, I thinkn that makes sense, will update.
fix: backward compatible maxTimeVariation
Co-authored-by: Daniel Goldman <dzgoldman@wesleyan.edu>
Great catch, updated the gasrefundenabled contract to be delegate call aware. 4844 gas refund changes will happen in a separate pr. |
rollup andbridge address ~10kNitro changes required:
prevMessageCount
,newMessageCount
and parameters have been removed, however it will continue to exist on the old sequencer inbox which wont be updated to have it removed. If this function abi was used for decoding historical logs we should instead do this with standard abi decoding.