Metric for any das.Aggregator Store errors, fixes: NIT-2550 #2410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there are errors sending to any backends in das.Aggregator.Store then the new metric arb_das_rpc_aggregator_store_error_gauge will be 1 until there is a call to Store with no errors. The metric will be 1 even if the Store succeeds, as long as at least one backend failed.
cla-bot
bot
added
the
s
Tristan-Wilson
requested review from
ganeshvanahalli,
amsanghi and
joshuacolvin0
amsanghi
previously approved these changes
Jun 21, 2024
Tristan-Wilson
changed the title
Tristan-Wilson
dismissed stale reviews from amsanghi and ganeshvanahalli
via
df0eddc
ganeshvanahalli
approved these changes
Jun 27, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there are errors sending to any backends in das.Aggregator.Store then the new metric arb_das_rpc_aggregator_store_error_gauge will be 1 until there is a call to Store with no errors. The metric will be 1 even if the Store succeeds, as long as at least one backend failed.