Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build arbitrator.h on test-go-deps #2438

Merged
merged 1 commit into from
Jun 27, 2024
Merged

build arbitrator.h on test-go-deps #2438

merged 1 commit into from
Jun 27, 2024

Conversation

tsahee
Copy link
Contributor

@tsahee tsahee commented Jun 27, 2024

loong overdue

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Jun 27, 2024
joshuacolvin0
joshuacolvin0 approved these changes Jun 27, 2024
View reviewed changes
Copy link
Member

@joshuacolvin0 joshuacolvin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tsahee tsahee merged commit cc9395f into master Jun 27, 2024
11 of 13 checks passed
@tsahee tsahee deleted the makefile_fix branch June 27, 2024 15:09
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuacolvin0 joshuacolvin0 joshuacolvin0 approved these changes

Assignees
No one assigned
Labels
design-approved s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tsahee @joshuacolvin0