Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NIT-1297] [Config-Change] Change comma separated string values in config to string slice #2480

Merged
merged 7 commits into from
Aug 8, 2024

Conversation

amsanghi
Copy link
Contributor

No description provided.

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Jul 11, 2024
@amsanghi amsanghi requested review from Tristan-Wilson and ganeshvanahalli and removed request for Tristan-Wilson July 11, 2024 06:33
@amsanghi amsanghi marked this pull request as ready for review July 11, 2024 06:34
Tristan-Wilson
Tristan-Wilson previously approved these changes Jul 11, 2024
@amsanghi amsanghi changed the title [NIT-1297] Change comma separated string values in config to string slice [NIT-1297] [Config-Change] Change comma separated string values in config to string slice Jul 11, 2024
Copy link
Contributor

@ganeshvanahalli ganeshvanahalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

joshuacolvin0
joshuacolvin0 previously approved these changes Jul 29, 2024
Copy link
Member

@joshuacolvin0 joshuacolvin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tsahee tsahee merged commit 60e7bf3 into master Aug 8, 2024
13 checks passed
@tsahee tsahee deleted the string_slice branch August 8, 2024 00:06
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design-approved s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants