Separate out the DA client into a separate binary #2533
Conversation
cla-bot
bot
added
the
s
daprovider/util.go
Outdated
|
|
||
| // RecordPreimagesTo takes in preimages map and returns a function that can be used | ||
| // In recording (hash,preimage) key value pairs into preimages map, when fetching payload through RecoverPayloadFromBatch | ||
| func RecordPreimagesTo(preimages map[arbutil.PreimageType]map[common.Hash][]byte) PreimageRecorder { |
There was a problem hiding this comment.
I saw this long type map[arbutil.PreimageType]map[common.Hash] in multiple places. Maybe create a type alias for it?
There was a problem hiding this comment.
I think this is a good idea and have aliased this as PreimagesMap for now. I don't foresee any issue with this but flagging this to @Tristan-Wilson to double check
|
I think I need some help understanding this PR, can you make some diagrams showing the relations between the components and what some typical configurations would look like? |
I've added the diagram showing the relations between components to the title comment. |
| @@ -0,0 +1,216 @@ | |||
| package main | |||
There was a problem hiding this comment.
cmd/ should have only small things that are only relevant to the binaries.
so this file makes sense here, but the "das" and "dasserver" subdirs should be moved somewhere else.
I think I do like the fact you removed it from "arbstate".. maybe under "/daprovider" or somewhere else?
There was a problem hiding this comment.
Makes sense! I also moved dasserver inside das directory since it made more sense to be placed in there
There was a problem hiding this comment.
In this PR the batch poster is trusting the response of the daprovider, authenticated by JWT. Can we require that #2371 is enabled if daprovider is used for extra assurance?
| dasServer, closeFn, err := dasserver.NewServer(ctx, &serverConfig, dataSigner, l1client, l1Reader, deployInfo.SequencerInbox) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
There was a problem hiding this comment.
If this is being initialized in the same process what's the point of communicating over TCP at all?
There was a problem hiding this comment.
I think the reasoning here is we would like to demonstrate that the current design and implementation works.
Redirecting to @PlasmaPower for confirmation.
This PR introduces
daclientlibrary and--da-providerconfig option that can be used to connect a node to any external DA service that implements the unified reader and writer interfaces while adhering to the response formats,...Resultstructs, available in/daprovider/daclient/daclient.go.We also separate out the current data availability implementation (das) into a new binary
daproviderthat can be used to start adas-serverwhich can in turn be used as a daprovider option above. To maintain backwards compatibility a nitro node does the above step by default when--data-availabilityconfig is provided.(note:
da-provideranddata-availabilitycannot be enabled together`)Thus enabling da providers to efficiently connect to nitro without having to alter any of the source code.
Below is the diagram showing multiple components and their working involved in this PR-
Resolves NIT-1158