[NIT-2689] Add custom native tracer for cargo stylus replay #2560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
s
tsahee
requested changes
Aug 14, 2024
| callArgs := argsForMulticall(vm.CALL, stylusMulticall, nil, []byte{0}) | ||
| evmCall := argsForMulticall(vm.CALL, evmMulticall, nil, []byte{0}) | ||
|
|
||
| for _, testCase := range []struct { |
There was a problem hiding this comment.
Not for now - but after both this and stylus_EVM are merged, we might be able to re-use some testcases between the two
gligneul
requested review from
ganeshvanahalli,
tsahee,
diegoximenes and
hkalodner
3 tasks
|
I created a PR on Cargo Stylus to port the JS tracer improvements and add an option to use the native tracer: OffchainLabs/cargo-stylus#84 I tested it with the test node, and the native tracer works as expected. |
diegoximenes
approved these changes
Aug 22, 2024
tsahee
approved these changes
Aug 24, 2024
| // Copyright 2024, Offchain Labs, Inc. | ||
| // For license information, see https://github.com/OffchainLabs/nitro/blob/master/LICENSE | ||
|
|
||
| package stack |
There was a problem hiding this comment.
this will fit very well in util/containers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, Cargo Stylus Replay uses a special JS tracer, which is not supported by 3rd party providers. This tracer captures all executed HostIOs and their metadata. This PR adds an equivalent native tracer (
stylusTracer) that makes it easier for 3rd party providers to expose it to their users.