Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(sharenow): remove resolution and add react path #422

Merged
merged 1 commit into from
May 27, 2022
Merged

chore(sharenow): remove resolution and add react path #422

merged 1 commit into from
May 27, 2022

Conversation

xzf0587
Copy link
Contributor

@xzf0587 xzf0587 commented May 26, 2022 •
edited
Loading

  1. remove resolution before npm install
  2. add react path to resolve

The problem of Ajv is caused by react-script update.
Refer to facebook/create-react-app#12155 for the root cause.
Refer to facebook/react#24304 (comment) for fixing it.

@xzf0587 xzf0587 requested review from hund030 and adashen May 27, 2022 02:28
hund030
hund030 approved these changes May 27, 2022
View reviewed changes
Copy link
Contributor

@hund030 hund030 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xzf0587 xzf0587 merged commit 09ab28f into dev May 27, 2022
@xzf0587 xzf0587 deleted the zhaofeng/sharenow/updte-react branch May 27, 2022 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hund030 hund030 hund030 approved these changes

@KennethBWSong KennethBWSong KennethBWSong approved these changes

@wenytang-ms wenytang-ms Awaiting requested review from wenytang-ms

@adashen adashen Awaiting requested review from adashen adashen is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xzf0587 @hund030 @KennethBWSong