Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move plotGrid() and related config class to {tlf} #888

Closed
IndrajeetPatil opened this issue Apr 21, 2022 · 1 comment · Fixed by #893
Closed

Move plotGrid() and related config class to {tlf} #888

IndrajeetPatil opened this issue Apr 21, 2022 · 1 comment · Fixed by #893

Comments

@IndrajeetPatil
Copy link
Member

It's a general plotting function with no ties to DataCombined, and so more appropriate for tlf than ospsuite.

The idea is that only plotting functions that are related to ospsuite objects should be hosted in it; more general-purpose plotting functionality should be part of tlf.
@IndrajeetPatil
Copy link
Member Author

@Yuri05 also agrees (#882 (comment)) with this move.

IndrajeetPatil added a commit to Open-Systems-Pharmacology/TLF-Library that referenced this issue Apr 23, 2022
@IndrajeetPatil
move plot grid function and class from ospsuite
84384b2 
cf. Open-Systems-Pharmacology/OSPSuite-R#888
@IndrajeetPatil IndrajeetPatil mentioned this issue Apr 23, 2022
Merged
IndrajeetPatil added a commit that referenced this issue Apr 23, 2022
@IndrajeetPatil
move plot grid to tlf
82ec88e 
To be considered after Open-Systems-Pharmacology/TLF-Library#246 is merged

closes #888
@IndrajeetPatil IndrajeetPatil mentioned this issue Apr 23, 2022
Merged
1 task
msevestre pushed a commit to Open-Systems-Pharmacology/TLF-Library that referenced this issue Apr 23, 2022
@IndrajeetPatil
move plot grid function and class from ospsuite (#246)
dd00853 
* move plot grid function and class from ospsuite

cf. Open-Systems-Pharmacology/OSPSuite-R#888

* remove references to ospsuite

* Update PlotGridConfiguration.Rd

* remove redundant test-coverage GHA
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move plot grid and config class to tlf Open-Systems-Pharmacology/OSPSuite-R
1 participant
@IndrajeetPatil