Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #718 and fixes build #1009

Merged
merged 1 commit into from
Jun 28, 2022
Merged

Fixes #718 and fixes build #1009

merged 1 commit into from
Jun 28, 2022

Conversation

msevestre
Copy link
Member

No description provided.

@msevestre msevestre requested a review from Yuri05 June 28, 2022 15:26
@Yuri05
Copy link
Member

Yuri05 commented Jun 28, 2022

The 64-bit change looks good.
Not sure about those new SVGs though. They contain this unnesessary "group" keyword in the caption (s. Open-Systems-Pharmacology/TLF-Library#326) and must be reverted back again as soon as this bug is fixed.
So maybe we should just temporarily disable the corresponding tests instead?

@msevestre
Copy link
Member Author

Well, I want to merge all the PR. So we can revert after this. @IndrajeetPatil said that the code was ok so I am just going with this now.

@msevestre msevestre merged commit 36f12d5 into develop Jun 28, 2022
@msevestre msevestre deleted the 718-message-32 branch June 28, 2022 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants